From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id AEEEBA2EDB
for <public@inbox.dpdk.org>; Tue, 1 Oct 2019 18:29:35 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 6268E1BE8A;
Tue, 1 Oct 2019 18:29:34 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id 479CD1B94A;
Tue, 1 Oct 2019 18:29:32 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
[10.5.11.15])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id A071B308212F;
Tue, 1 Oct 2019 16:29:31 +0000 (UTC)
Received: from [10.36.118.72] (unknown [10.36.118.72])
by smtp.corp.redhat.com (Postfix) with ESMTP id 7D9475D71C;
Tue, 1 Oct 2019 16:29:27 +0000 (UTC)
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie
<tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>, stable@dpdk.org
References: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <4057f198-1faa-708e-bf60-075d53b92a97@redhat.com>
Date: Tue, 1 Oct 2019 17:29:26 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
Thunderbird/68.1.0
MIME-Version: 1.0
In-Reply-To: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.47]); Tue, 01 Oct 2019 16:29:31 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx
queue setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi,
On 01/10/2019 16:44, Andrew Rybchenko wrote:
> From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
>
> Deferred start Rx queue is not supported by the driver.
>
> Fixes: 0748be2cf9a2 ("ethdev: queue start and stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/net/virtio/virtio_rxtx.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
> index 929aa4cbd..9c8c617f7 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -929,6 +929,11 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,
>
const struct rte_eth_rxconf *rx_conf __rte_unused,
^^^^^^^^^^^^
The unused can be removed now
> PMD_INIT_FUNC_TRACE();
>
> + if (rx_conf->rx_deferred_start) {
> + PMD_INIT_LOG(ERR, "Rx deferred start is not supported");
> + return -EINVAL;
> + }
> +
> if (nb_desc == 0 || nb_desc > vq->vq_nentries)
> nb_desc = vq->vq_nentries;
> vq->vq_free_cnt = RTE_MIN(vq->vq_free_cnt, nb_desc);
>