From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9693A0C41; Wed, 20 Oct 2021 00:20:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65F4D40687; Wed, 20 Oct 2021 00:20:55 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id D113D40142 for ; Wed, 20 Oct 2021 00:20:53 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4D1215C00C6; Tue, 19 Oct 2021 18:20:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 19 Oct 2021 18:20:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= qo+35mgdoFeZceeokDsDetG54uxP9EKnQT83p9EzhRU=; b=O6mtktzNyWzPSBRV ZEMDgySITAe6SoCs8660C3PpxNQGgYdX2UEBU5OnegpLvopLHOzXVG7UckLzmopf u6iyLLJ4IvftchNnU7yhnZ2Mi1LY8sdz+WOLvmlqqhCYTzynp/8V6cC5j0e6rk2L uVtM9R/OtxtAIKCOslQnECWbb126bUreXa7KVepCHMJoVVg6HRv3r8po+0qvcD0e j5HjwHHAAqbzN1C6InaXveOYWK+zQjTgUs6VDbSu9VrSBRW0+x5dLwGrBmSe4MrQ j+HBK7z/fTNIt3ESJ4kLpoEGynjGxfo3+8Wp5FhG296xDsyHGFwqM/swRFK/ViCK j4eB4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=qo+35mgdoFeZceeokDsDetG54uxP9EKnQT83p9Ezh RU=; b=LvW4RoAG76QHg112zX8AySX7dWCP9yPeVKCvQ/ODYvFTz/C45Pe4PNeLA W37fI+NI4ikn/il0gI/nN5nDTEgMNrk27Ii2CTJrnvefMKQ4WjRAG0iD1GMjFpPY tCwe9xGgUcirDV3ng4N5y+5gokHjAaxbBCgoOQueKRVZSHReSJK3ltEB8YtTnogB zOJCko3QkHqXj8slwAckDm6UV8Md32IcRORX8wLXLq2HemPv3IDT6Fms9iC8RMnb QFrRqCxh8ClROaxGqKZDbF35P4CCQ6JCGno6hFX7TK3bVT0spbWr1d5Mdl/qfW4x URHL/acX+4Tjx0QHSDQCH+amam1Eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvfedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Oct 2021 18:20:51 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , Ferruh Yigit Cc: dev@dpdk.org, Konstantin Ananyev Date: Wed, 20 Oct 2021 00:20:49 +0200 Message-ID: <4058515.qi23bM2isA@thomas> In-Reply-To: <0ce43d7d-2d01-d332-1a22-1062a7ea489e@intel.com> References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru> <945d03fb-251b-eb75-f815-950754652b7b@oktetlabs.ru> <0ce43d7d-2d01-d332-1a22-1062a7ea489e@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2021 00:05, Ferruh Yigit: > On 10/19/2021 7:07 PM, Andrew Rybchenko wrote: > > On 10/19/21 2:55 PM, Ferruh Yigit wrote: > >> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote: > >>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved > >>> right now is a good chance to make a cleanup. > >>> > >>> No strong opinion, but I think it would be useful for the future. > >>> > >>> Make be at least some fixes from below could be accepted. > >>> > >>> Andrew Rybchenko (5): > >>> ethdev: avoid documentation in next lines > >>> ethdev: fix Rx/Tx spelling in just moved structures > >>> ethdev: remove reserved fields from internal structures > >>> ethdev: make device and data structures readable > >>> ethdev: remove full stop after short comments and references > >>> > >> > >> Overall +1 to these changes, I think this release is the opportunity > >> to have changes like this. > >> > >> But as far as I can see only new moved code updated in 'ethdev_driver.h', > >> why not update whole 'ethdev_driver.h'? > > > > Simply don't want to complicate search by git blame because of cosmetic > > changes. No strong opinion, but decided to go this way for now. > > Normally agree to NOT get cosmetic changes because the reason you mentioned, > noise in the git history. But in this release we already shuffled things a bit, > that is why I think it is good opportunity to get these kind of changes. > > Also there will be some inconsistencies in 'ethdev_driver.h' after your changes, > like 'RX' -> 'Rx' change done in one patch, but half of the file still uses 'RX'. > > I also don't have strong opinion, but my preference is either fix all, or none. > Lets get some more comments. OK to fix all, given ethdev is already shuffled a lot.