From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7339B10B7 for ; Sat, 3 Mar 2018 15:05:37 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 3ABA2600061; Sat, 3 Mar 2018 14:05:35 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 3 Mar 2018 14:05:25 +0000 To: Anatoly Burakov , CC: Thomas Monjalon , , , , , , , , , , , , , , , References: From: Andrew Rybchenko Message-ID: <405c4b97-4561-6ef7-5844-fdc0cdfaabc5@solarflare.com> Date: Sat, 3 Mar 2018 17:05:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23696.003 X-TM-AS-Result: No--12.639900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1520085936-c2TqVx0XrB26 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 31/41] ethdev: use contiguous allocation for DMA memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2018 14:05:37 -0000 On 03/03/2018 04:46 PM, Anatoly Burakov wrote: > This fixes the following drivers in one go: Does it mean that these drivers are broken in the middle of patch set and fixed now? If so, it would be good to avoid it. It breaks bisect. > grep -Rl rte_eth_dma_zone_reserve drivers/ > > drivers/net/avf/avf_rxtx.c > drivers/net/thunderx/nicvf_ethdev.c > drivers/net/e1000/igb_rxtx.c > drivers/net/e1000/em_rxtx.c > drivers/net/fm10k/fm10k_ethdev.c > drivers/net/vmxnet3/vmxnet3_rxtx.c > drivers/net/liquidio/lio_rxtx.c > drivers/net/i40e/i40e_rxtx.c > drivers/net/sfc/sfc.c > drivers/net/ixgbe/ixgbe_rxtx.c > drivers/net/nfp/nfp_net.c > > Signed-off-by: Anatoly Burakov > --- > lib/librte_ether/rte_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 0590f0c..7935230 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -3401,7 +3401,8 @@ rte_eth_dma_zone_reserve(const struct rte_eth_dev *dev, const char *ring_name, > if (mz) > return mz; > > - return rte_memzone_reserve_aligned(z_name, size, socket_id, 0, align); > + return rte_memzone_reserve_aligned_contig(z_name, size, socket_id, 0, > + align); > } > > int