From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA652A0A0A; Thu, 3 Jun 2021 10:17:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 502724069F; Thu, 3 Jun 2021 10:17:18 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E74C640689 for ; Thu, 3 Jun 2021 10:17:16 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 815C07F519; Thu, 3 Jun 2021 11:17:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 815C07F519 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1622708236; bh=Eo9g6kukXEkc264/hHRd8PhXs9JIlYo6XVS0lZeDpp0=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=eK1ziMoO2pPxaQe7NTrkBgkJtM4vCICF7ffAyC6er9lGCxKKJuAKzkGHvBRcq97sp Vfah1s4Q3vTRISPl1TwRPBKEoaXpj8AdKeI+6Sr37o10MYF2Y7GUisr3aUWCfN9At7 jnA728RFxi86JSRkGB7z19q0ZeJDxPztraSv9HWM= To: Alvin Zhang , qi.z.zhang@intel.com Cc: dev@dpdk.org References: <20210603031214.19892-1-alvinx.zhang@intel.com> <20210603080352.10924-1-alvinx.zhang@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <405f6c00-3f34-dd84-d0e5-c2e00180df5b@oktetlabs.ru> Date: Thu, 3 Jun 2021 11:17:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210603080352.10924-1-alvinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add IPv4 checksum RSS offload type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/3/21 11:03 AM, Alvin Zhang wrote: > This patch defines new RSS offload type for IPv4 checksum, > which is required when users want to distribute packets based > on the IPv4 checksum field. > > For example "flow create 0 ingress pattern eth / ipv4 / end > actions rss types ipv4-chksum end queues end / end", this flow > causes all matching packets to be distributed to queues on > basis of IPv4 checksum. > > Signed-off-by: Alvin Zhang The patch LGTM now. I hope we'll have a PMD in the release cycle which supports it. In fact it is a funny idea. Let's consider a TCP connection and routing change with one extra hop on the way while the connection is alive. Or a UDP stream in the same conditions. If so, TTL will different, checksum changes and connection packets may be delivered to a different Rx queue. May be sometimes it is not important and/or can't happen. L4 checksum sounds better from this point of view since it covers IP addresses and transport ports and less bits to hash. The only concern is distribution fairness, but I keep the topic to those who understand corresponding math better. > --- > app/test-pmd/cmdline.c | 2 ++ > app/test-pmd/config.c | 1 + > lib/ethdev/rte_ethdev.h | 1 + > 3 files changed, 4 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 0268b18..32da066 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -2254,6 +2254,8 @@ struct cmd_config_rss { > rss_conf.rss_hf = ETH_RSS_ECPRI; > else if (!strcmp(res->value, "mpls")) > rss_conf.rss_hf = ETH_RSS_MPLS; > + else if (!strcmp(res->value, "ipv4-chksum")) > + rss_conf.rss_hf = ETH_RSS_IPV4_CHKSUM; > else if (!strcmp(res->value, "none")) > rss_conf.rss_hf = 0; > else if (!strcmp(res->value, "level-default")) { > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 43c79b5..2c0c415 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -140,6 +140,7 @@ > { "gtpu", ETH_RSS_GTPU }, > { "ecpri", ETH_RSS_ECPRI }, > { "mpls", ETH_RSS_MPLS }, > + { "ipv4-chksum", ETH_RSS_IPV4_CHKSUM }, > { NULL, 0 }, > }; > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index faf3bd9..f10d834 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -537,6 +537,7 @@ struct rte_eth_rss_conf { > #define ETH_RSS_PPPOE (1ULL << 31) > #define ETH_RSS_ECPRI (1ULL << 32) > #define ETH_RSS_MPLS (1ULL << 33) > +#define ETH_RSS_IPV4_CHKSUM (1ULL << 34) > > /* > * We use the following macros to combine with above ETH_RSS_* for >