[PATCH 1/2] remove extra blank line at eof

[PATCH 1/2] remove extra blank line at eof

[Stephen Hemminger]

These source files all had unnecessary blank line at end of file.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/iavf/iavf_adminq.c     | 1 -
 drivers/common/mlx5/mlx5_common_log.h | 1 -
 drivers/net/cxgbe/smt.h               | 1 -
 drivers/net/dpaa2/mc/dpni.c           | 1 -
 drivers/net/hinic/hinic_pmd_flow.c    | 1 -
 drivers/net/iavf/iavf_generic_flow.c  | 1 -
 drivers/net/ionic/ionic_ethdev.h      | 1 -
 drivers/net/ionic/ionic_mac_api.c     | 1 -
 drivers/net/mlx5/linux/meson.build    | 1 -
 drivers/net/mlx5/mlx5_flow_dv.c       | 1 -
 drivers/net/mlx5/mlx5_rx.c            | 1 -
 drivers/net/netvsc/meson.build        | 1 -
 drivers/net/nfp/nfp_rxtx.h            | 1 -
 drivers/net/ngbe/ngbe_ptypes.c        | 1 -
 drivers/net/octeontx_ep/meson.build   | 1 -
 drivers/net/octeontx_ep/otx2_ep_vf.h  | 1 -
 drivers/net/txgbe/txgbe_flow.c        | 1 -
 drivers/net/txgbe/txgbe_ptypes.c      | 1 -
 drivers/net/txgbe/txgbe_rxtx.c        | 1 -
 drivers/regex/cn9k/meson.build        | 1 -
 lib/ethdev/ethdev_driver.c            | 1 -
 lib/ethdev/ethdev_private.c           | 1 -
 22 files changed, 22 deletions(-)

diff --git a/drivers/common/iavf/iavf_adminq.c b/drivers/common/iavf/iavf_adminq.c
index 9c36e8908e59..8b305c0fe3eb 100644
--- a/drivers/common/iavf/iavf_adminq.c
+++ b/drivers/common/iavf/iavf_adminq.c
@@ -963,4 +963,3 @@ enum iavf_status iavf_clean_arq_element(struct iavf_hw *hw,
 
 	return ret_code;
 }
-
diff --git a/drivers/common/mlx5/mlx5_common_log.h b/drivers/common/mlx5/mlx5_common_log.h
index 26b13fedaf2e..cabae3866b58 100644
--- a/drivers/common/mlx5/mlx5_common_log.h
+++ b/drivers/common/mlx5/mlx5_common_log.h
@@ -18,4 +18,3 @@ extern int mlx5_common_logtype;
 		PMD_DRV_LOG_CPAREN)
 
 #endif /* RTE_PMD_MLX5_COMMON_LOG_H_ */
-
diff --git a/drivers/net/cxgbe/smt.h b/drivers/net/cxgbe/smt.h
index e6e8aea964e1..a70e3a208575 100644
--- a/drivers/net/cxgbe/smt.h
+++ b/drivers/net/cxgbe/smt.h
@@ -42,4 +42,3 @@ struct smt_entry *cxgbe_smt_alloc_switching(struct rte_eth_dev *dev, u8 *smac);
 void cxgbe_smt_release(struct smt_entry *e);
 
 #endif  /* __CXGBE_SMT_H_ */
-
diff --git a/drivers/net/dpaa2/mc/dpni.c b/drivers/net/dpaa2/mc/dpni.c
index 7a2bc15eb4da..c5cc9302f987 100644
--- a/drivers/net/dpaa2/mc/dpni.c
+++ b/drivers/net/dpaa2/mc/dpni.c
@@ -3118,4 +3118,3 @@ int dpni_set_port_cfg(struct fsl_mc_io *mc_io, uint32_t cmd_flags,
 	/* send command to MC */
 	return mc_send_command(mc_io, &cmd);
 }
-
diff --git a/drivers/net/hinic/hinic_pmd_flow.c b/drivers/net/hinic/hinic_pmd_flow.c
index 2cf24ebcf64e..358b372e07e8 100644
--- a/drivers/net/hinic/hinic_pmd_flow.c
+++ b/drivers/net/hinic/hinic_pmd_flow.c
@@ -3311,4 +3311,3 @@ const struct rte_flow_ops hinic_flow_ops = {
 	.destroy = hinic_flow_destroy,
 	.flush = hinic_flow_flush,
 };
-
diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c
index 2befa125ac90..d1abcbd54266 100644
--- a/drivers/net/iavf/iavf_generic_flow.c
+++ b/drivers/net/iavf/iavf_generic_flow.c
@@ -2334,4 +2334,3 @@ iavf_flow_query(struct rte_eth_dev *dev,
 	}
 	return ret;
 }
-
diff --git a/drivers/net/ionic/ionic_ethdev.h b/drivers/net/ionic/ionic_ethdev.h
index 652f28c97d57..9304e170dec3 100644
--- a/drivers/net/ionic/ionic_ethdev.h
+++ b/drivers/net/ionic/ionic_ethdev.h
@@ -23,4 +23,3 @@
 int ionic_dev_link_update(struct rte_eth_dev *eth_dev, int wait_to_complete);
 
 #endif /* _IONIC_ETHDEV_H_ */
-
diff --git a/drivers/net/ionic/ionic_mac_api.c b/drivers/net/ionic/ionic_mac_api.c
index c0ea042bc5d0..411d84b57806 100644
--- a/drivers/net/ionic/ionic_mac_api.c
+++ b/drivers/net/ionic/ionic_mac_api.c
@@ -60,4 +60,3 @@ ionic_set_mac_type(struct ionic_hw *hw)
 
 	return err;
 }
-
diff --git a/drivers/net/mlx5/linux/meson.build b/drivers/net/mlx5/linux/meson.build
index 553024135601..e541d25c183d 100644
--- a/drivers/net/mlx5/linux/meson.build
+++ b/drivers/net/mlx5/linux/meson.build
@@ -11,4 +11,3 @@ sources += files(
         'mlx5_vlan_os.c',
         'mlx5_flow_os.c',
 )
-
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index ef9c66eddf06..b430754ea918 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -18284,4 +18284,3 @@ const struct mlx5_flow_driver_ops mlx5_flow_dv_drv_ops = {
 };
 
 #endif /* HAVE_IBV_FLOW_DV_SUPPORT */
-
diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c
index 11ea935d72f0..e5eea0ad949e 100644
--- a/drivers/net/mlx5/mlx5_rx.c
+++ b/drivers/net/mlx5/mlx5_rx.c
@@ -1187,4 +1187,3 @@ mlx5_check_vec_rx_support(struct rte_eth_dev *dev __rte_unused)
 {
 	return -ENOTSUP;
 }
-
diff --git a/drivers/net/netvsc/meson.build b/drivers/net/netvsc/meson.build
index 399400dd0114..bb6225d05a10 100644
--- a/drivers/net/netvsc/meson.build
+++ b/drivers/net/netvsc/meson.build
@@ -15,4 +15,3 @@ sources = files(
         'hn_rxtx.c',
         'hn_vf.c',
 )
-
diff --git a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h
index 1a813ded1539..dec1857da384 100644
--- a/drivers/net/nfp/nfp_rxtx.h
+++ b/drivers/net/nfp/nfp_rxtx.h
@@ -299,4 +299,3 @@ uint16_t nfp_net_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
  * indent-tabs-mode: t
  * End:
  */
-
diff --git a/drivers/net/ngbe/ngbe_ptypes.c b/drivers/net/ngbe/ngbe_ptypes.c
index d6d82105c975..33f20e924720 100644
--- a/drivers/net/ngbe/ngbe_ptypes.c
+++ b/drivers/net/ngbe/ngbe_ptypes.c
@@ -297,4 +297,3 @@ u8 ngbe_encode_ptype(u32 ptype)
 
 	return ptid;
 }
-
diff --git a/drivers/net/octeontx_ep/meson.build b/drivers/net/octeontx_ep/meson.build
index b15646b82a47..957e8fc48a29 100644
--- a/drivers/net/octeontx_ep/meson.build
+++ b/drivers/net/octeontx_ep/meson.build
@@ -8,4 +8,3 @@ sources = files(
         'otx_ep_vf.c',
         'otx2_ep_vf.c',
 )
-
diff --git a/drivers/net/octeontx_ep/otx2_ep_vf.h b/drivers/net/octeontx_ep/otx2_ep_vf.h
index dc720368abf1..757eeae9f007 100644
--- a/drivers/net/octeontx_ep/otx2_ep_vf.h
+++ b/drivers/net/octeontx_ep/otx2_ep_vf.h
@@ -139,4 +139,3 @@ struct otx2_ep_instr_64B {
 };
 
 #endif /*_OTX2_EP_VF_H_ */
-
diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c
index 6d7fd1842843..d0093c0163d2 100644
--- a/drivers/net/txgbe/txgbe_flow.c
+++ b/drivers/net/txgbe/txgbe_flow.c
@@ -3150,4 +3150,3 @@ const struct rte_flow_ops txgbe_flow_ops = {
 	.destroy = txgbe_flow_destroy,
 	.flush = txgbe_flow_flush,
 };
-
diff --git a/drivers/net/txgbe/txgbe_ptypes.c b/drivers/net/txgbe/txgbe_ptypes.c
index 0ed757d820e2..e1299d736372 100644
--- a/drivers/net/txgbe/txgbe_ptypes.c
+++ b/drivers/net/txgbe/txgbe_ptypes.c
@@ -672,4 +672,3 @@ txgbe_ptype_table_tn[TXGBE_PTID_MAX] __rte_cache_aligned = {
 		RTE_PTYPE_TUNNEL_VXLAN | RTE_PTYPE_INNER_L2_ETHER |
 		RTE_PTYPE_INNER_L3_IPV4_EXT | RTE_PTYPE_INNER_L4_UDP,
 };
-
diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c
index 35b77cb271ba..ac1bba08a337 100644
--- a/drivers/net/txgbe/txgbe_rxtx.c
+++ b/drivers/net/txgbe/txgbe_rxtx.c
@@ -5108,4 +5108,3 @@ txgbe_config_rss_filter(struct rte_eth_dev *dev,
 
 	return 0;
 }
-
diff --git a/drivers/regex/cn9k/meson.build b/drivers/regex/cn9k/meson.build
index bb0504fba12c..06c906710c7e 100644
--- a/drivers/regex/cn9k/meson.build
+++ b/drivers/regex/cn9k/meson.build
@@ -22,4 +22,3 @@ sources = files(
 
 deps += ['bus_pci', 'regexdev']
 deps += ['common_cnxk', 'mempool_cnxk']
-
diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c
index 7184e0a6579a..a285f213f0a8 100644
--- a/lib/ethdev/ethdev_driver.c
+++ b/lib/ethdev/ethdev_driver.c
@@ -767,4 +767,3 @@ rte_eth_switch_domain_free(uint16_t domain_id)
 
 	return 0;
 }
-
diff --git a/lib/ethdev/ethdev_private.c b/lib/ethdev/ethdev_private.c
index 84dc0b320ed0..48090c879af3 100644
--- a/lib/ethdev/ethdev_private.c
+++ b/lib/ethdev/ethdev_private.c
@@ -432,4 +432,3 @@ eth_dev_tx_queue_config(struct rte_eth_dev *dev, uint16_t nb_queues)
 	dev->data->nb_tx_queues = nb_queues;
 	return 0;
 }
-
-- 
2.34.1

[PATCH 2/2] examples: add missing newline at eof

[Stephen Hemminger]

The text file did not end with newline.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 examples/flow_classify/ipv4_rules_file.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/flow_classify/ipv4_rules_file.txt b/examples/flow_classify/ipv4_rules_file.txt
index dfa0631fcc09..cd5215736aaf 100644
--- a/examples/flow_classify/ipv4_rules_file.txt
+++ b/examples/flow_classify/ipv4_rules_file.txt
@@ -11,4 +11,4 @@
 6.7.8.9/16 192.168.0.36/16 10 : 0xffff 11 : 0xffff 6/0xfe 7
 6.7.8.9/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 8
 #error rules
-#9.8.7.6/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 9
\ No newline at end of file
+#9.8.7.6/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 9
-- 
2.34.1

Re: [PATCH 2/2] examples: add missing newline at eof

[Thomas Monjalon]

25/02/2022 18:47, Stephen Hemminger:
> The text file did not end with newline.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Series applied, thanks for the cleanup.

Could we add a check in checkpatch to avoid it in future?

Re: [PATCH 2/2] examples: add missing newline at eof

[Stephen Hemminger]

On Sun, 27 Feb 2022 21:27:40 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 25/02/2022 18:47, Stephen Hemminger:
> > The text file did not end with newline.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
> 
> Series applied, thanks for the cleanup.
> 
> Could we add a check in checkpatch to avoid it in future?
> 
> 

The only tool I saw to find these was
 pcregrep -LMr '\n\Z'

But probably possible with a complex python one-liner...

Re: [PATCH 2/2] examples: add missing newline at eof

[Thomas Monjalon]

27/02/2022 22:32, Stephen Hemminger:
> On Sun, 27 Feb 2022 21:27:40 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 25/02/2022 18:47, Stephen Hemminger:
> > > The text file did not end with newline.
> > > 
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
> > 
> > Series applied, thanks for the cleanup.
> > 
> > Could we add a check in checkpatch to avoid it in future?
> 
> The only tool I saw to find these was
>  pcregrep -LMr '\n\Z'
> 
> But probably possible with a complex python one-liner...

It can be done with diff:
	diff /dev/null $file | tail -1 | grep '^\\ No newline'