From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mbuf: enforce alignment of mbuf private area
Date: Mon, 03 Aug 2015 00:35:32 +0200 [thread overview]
Message-ID: <4068420.gylT6sbKzz@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836A6B5A2@irsmsx105.ger.corp.intel.com>
> > It looks better to have a data buffer address that is aligned to
> > 8 bytes. This is the case when there is no mbuf private area, but
> > if there is one, the alignment depends on the size of this area
> > that is located between the mbuf structure and the data buffer.
> >
> > Indeed, some drivers expects to have the buffer address aligned
> > to an even address, and moreover an unaligned buffer may impact
> > the performance when accessing to network headers.
> >
> > Add a check in rte_pktmbuf_pool_create() to verify the alignment
> > constraint before creating the mempool. For applications that use
> > the alternative way (direct call to rte_mempool_create), also
> > add an assertion in rte_pktmbuf_init().
> >
> > By the way, also add the MBUF log type.
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
next prev parent reply other threads:[~2015-08-02 22:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 15:07 [dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when mbuf private area size is odd Martin Weiser
2015-07-29 18:12 ` Ananyev, Konstantin
2015-07-29 20:24 ` Zhang, Helin
2015-07-30 8:12 ` Olivier MATZ
2015-07-30 9:00 ` Ananyev, Konstantin
2015-07-30 9:10 ` Olivier MATZ
2015-07-30 9:43 ` Ananyev, Konstantin
2015-07-30 11:22 ` Olivier MATZ
2015-07-30 13:47 ` Thomas Monjalon
2015-07-30 13:56 ` [dpdk-dev] [PATCH] mbuf: enforce alignment of mbuf private area Olivier Matz
2015-07-30 14:13 ` Ananyev, Konstantin
2015-07-30 16:06 ` Olivier MATZ
2015-07-30 15:33 ` Zhang, Helin
2015-07-30 16:07 ` Olivier MATZ
2015-07-30 16:22 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2015-07-30 16:25 ` Zhang, Helin
2015-07-30 21:28 ` Ananyev, Konstantin
2015-08-02 22:35 ` Thomas Monjalon [this message]
2015-08-02 22:32 ` [dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when mbuf private area size is odd Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4068420.gylT6sbKzz@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).