From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45208A0351; Sun, 27 Feb 2022 20:14:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD99A4068A; Sun, 27 Feb 2022 20:14:51 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 8F02940683; Sun, 27 Feb 2022 20:14:50 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2778E5C00F7; Sun, 27 Feb 2022 14:14:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 27 Feb 2022 14:14:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=5FSam8N+yUy08R ZvZbtv2P5RPMuzUgTi91T4Spau2KQ=; b=c2rFHBCzDvR3IVhnhesyuTtZioUqSN 7D7mSiwF8f8L+Zfdp+z/VuQ7j382aabbvRaZ9IpO0st5nbk/UzI4T3e/J2k5yWxx Hv2f3bdYNF4Vv/s/Anfgeg/9ADi5PnS6YLQKCArOVOOw0ew9eY/8b/h61j9Km320 D9lYpwmDs0ob1RyEa29DE0j4O/7or2duCMYrUVtfADxwm7IHVpHjEH/5N0pKEyUp hymS59DHhyVVVlTnRv23RdsDrQPn4qg8WzbW7VahppIgzcKay8IEDxs7oZjkcQpz PifyjfyThTKMxmyv2xJkrOs76WT22+IL6MY6j4uMsb9exg/VYE3mdSJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5FSam8N+yUy08RZvZbtv2P5RPMuzUgTi91T4Spau2 KQ=; b=dxtebVZNNUYMEmDwnwxoTSgSwevpyUZEcfaBhX+zjEBQ5ZQMJj8Kecs0O Dbz/m0w1x4vu+Wb7Qnw4ykh0lBz4ytcBY7mvDrCSHfLhsG0ezAUFIah8ZPt/kQZb 90N85/TSh/Q9miAJXXhrIgYGyXhN+XmdIESW+WjZ3YPGJJTxiaBjC1amvWQTU+9v Un8xhBB4wgAxWgKcwiCARWmlJ5Yx81+3CtZbnCMjshayd4q9n7XSEEcFlqCF4DaM q8hPmHismZ74EatZkMkrlaalItQb5y3S56FjvE3R7KVH03pn7DHRcfzDyLx+Cewf 41ewfziLp9mS/gNZ8MCP54IbAdf3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleekgdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 27 Feb 2022 14:14:47 -0500 (EST) From: Thomas Monjalon To: Michal Krawczyk Cc: dev@dpdk.org, stable@dpdk.org, upstream@semihalf.com, shaibran@amazon.com, hkalra@marvell.com Subject: Re: [PATCH] bus/pci: assign driver's pointer before mapping Date: Sun, 27 Feb 2022 20:14:45 +0100 Message-ID: <4071325.usQuhbGJ8B@thomas> In-Reply-To: <20220119145037.28125-1-mk@semihalf.com> References: <20220119145037.28125-1-mk@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/01/2022 15:50, Michal Krawczyk: > Patch changing the way of accessing interrupt handle also changed order > of the rte_pci_map_device() call and rte_pci_device:driver assignment. > It was causing issues with Write Combine mapping on the Linux platform > if it was used with the igb_uio module. > > Linux implementation of pci_uio_map_resource_by_index(), which is called > by rte_pci_map_device(), needs access to the device's driver. Otherwise > it won't be able to check the driver's flags and won't respect them. > > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") > Cc: hkalra@marvell.com > Cc: stable@dpdk.org > > Signed-off-by: Michal Krawczyk Looks to be a simple change. I hope there is no side effect. Applied, thanks.