From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 903DF5A64
 for <dev@dpdk.org>; Thu, 16 Jul 2015 18:13:09 +0200 (CEST)
Received: by wgxm20 with SMTP id m20so62404541wgx.3
 for <dev@dpdk.org>; Thu, 16 Jul 2015 09:13:09 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=evsSvCelRdwfDWgrGIqRbFUiHNVnxXFbri0rcNaHzQ0=;
 b=OP3ygUo2XOilrqDETbDfVpHus+FKkLy7WoY22i5jYl5EM3aPs33ejcPg/u2k+LnRUC
 Zn8XmeNNnDYTu4kXvNTBhkAEImjnT348Q1sLXb1Yhlx0X915mS1YbBid10FaquwQgxkq
 O8eILHnyC/icI5+VGy1Dde7ahgQbZ+NQHmtB+OKUYqnp2hlcY/M4EFJJtaNl5TvIukTN
 RJVmJvQlbrVJAsqsYBmjZvNchuQxQ1SJeUt4aL7YnpubFCSmcilUHPBiM1gi4bFYitcu
 G9qswjfU8pJLy2f8DdvN7J6RvaB+6ybxIkvcTQiyBgb3xYIgMdYVxIYAeqpxWal2VcNH
 BH9Q==
X-Gm-Message-State: ALoCoQmSncEwm5eAh+RT0mfK+t6jChtE/+XpcTSMMeaWIb6mladx963w8T1y+KRs1IpuejEdZR4m
X-Received: by 10.194.59.212 with SMTP id b20mr19311321wjr.31.1437063189452;
 Thu, 16 Jul 2015 09:13:09 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210])
 by smtp.gmail.com with ESMTPSA id s16sm3972469wib.16.2015.07.16.09.13.08
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 16 Jul 2015 09:13:08 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Date: Thu, 16 Jul 2015 18:11:57 +0200
Message-ID: <4071939.eQPuFrO73t@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8959DD@SHSMSX104.ccr.corp.intel.com>
References: <6168490.VZvRJEXbFC@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8959DD@SHSMSX104.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] mbuf offload flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jul 2015 16:13:09 -0000

2015-07-16 15:50, Zhang, Helin:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Helin,
> > 
> > In commit http://dpdk.org/browse/dpdk/commit/?id=c22265f6fd4cdc, some
> > fake flags were added:
> > 
> > #define PKT_RX_EIP_CKSUM_BAD (0ULL << 0)  /**< External IP header
> > checksum error. */
> > #define PKT_RX_OVERSIZE      (0ULL << 0)  /**< Num of desc of an RX pkt
> > oversize. */
> > #define PKT_RX_HBUF_OVERFLOW (0ULL << 0)  /**< Header buffer overflow.
> > */
> > #define PKT_RX_RECIP_ERR     (0ULL << 0)  /**< Hardware processing error.
> > */
> > #define PKT_RX_MAC_ERR       (0ULL << 0)  /**< MAC error. */
> > 
> > Can we remove them?
> 
> Yes, I agree with you, except PKT_RX_EIP_CKSUM_BAD.

It is 0. Removing it shouldn't hurt.

> > In a tunnel case, what means PKT_RX_IP_CKSUM_BAD and
> > PKT_RX_L4_CKSUM_BAD?
> > Inner or outer?
> > The API comment must be updated.
> 
> Currently PKT_RX_EIP_CKSUM_BAD means outer IP checksum error.
> We may need to re-think it?
> PKT_RX_IP_CKSUM_BAD for outer for tunnel case, and add a new one for inner IP checksum error case?

Yes.
Maybe that having CKSUM_OK would be better to be sure it has been checked.

> For L4, do we need both outer and inner for tunnel case? One might be enough.
> We can add one more for L4 checksum error, when it is really needed. For now, I don't see any case.

I don't know.