From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70343A0093; Mon, 7 Mar 2022 17:51:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FFA540688; Mon, 7 Mar 2022 17:51:47 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 931D84014E for ; Mon, 7 Mar 2022 17:51:45 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 436E95C01B1; Mon, 7 Mar 2022 11:51:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 07 Mar 2022 11:51:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=e0LjqiDBiEEZDF r701J/iffDx1T1cGaMdxR9XmrPN8Y=; b=r5fRSdDy6BN/d+RJTSSZOitRYetyn4 D1b8IUQaZBa6aQ5YqWvd9JLTXxKpkFklsZrl+1YJeInhqpd4EeMxtqrJxuAZSVTe qSF3FMbI0lU+fI6nsI5DAWt+OiV46Q7xJZamjfZHzcF9/dv79IKlOOhlKx6vVydd 7rHBhDa4GLTb5+JNP7i8yayHodzZi+PdR1UQGf+8D5mGLI6fOa/9dXxLRZT6ToxG rnIGekP3I0Jvw49anz+oZSVtXMyYehNoGrpqayiCQgfHtdNS3wNMENM1xB9Azq17 l/jcnLU/hnPr1dlqFuZVBm8PyWNH4uylzVCY/QjdsWNV9eMFok/wkkmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=e0LjqiDBiEEZDFr701J/iffDx1T1cGaMdxR9XmrPN 8Y=; b=KyeqwjECZGHz7GJ9qghd7pR8Gf9VEBI6QuLq5LhqBDn0fxfroBz9+ZClZ 0MsIB12eKizf8MwN8MFn6tWhYM7qKPiF4UaYCNRv915qnVGWD1k1xFswhmTnIwsz fSpls8iQqvDc9r4qvX0GbaxeQPRURnyxruWaNDFeuptcC4QKa53AD03yc3RbRbrh KG8hePbk9L9HYsRS8BGcVxlN2MoCzRBCjuWV5tUL7g5PcEKmWaCxhq2TIgXSQ3fV 6xpmkCRysRIMdziqgFnzXmSRHReRmwxNQB+nQ9xm8yLUNtU7ZYbRI13OSHglMEYD ngtGiZHfzkBn5Vd0lE7yLMMbrQ0og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddugedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Mar 2022 11:51:44 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org Subject: Re: [PATCH] bus/pci: enhance driver pointer documentation Date: Mon, 07 Mar 2022 17:51:43 +0100 Message-ID: <4072114.jZfb76A358@thomas> In-Reply-To: <20220301105354.13323-1-david.marchand@redhat.com> References: <20220301105354.13323-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/03/2022 11:53, David Marchand: > Setting driver pointer before mapping required for write combining > support since commit 4a928ef9f611 ("bus/pci: enable write combining > during mapping"). > > Move comments that got separated after different changes. > Also change the condition relying on dev->driver itself. > > Signed-off-by: David Marchand Applied, thanks.