From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAB9FA09DF; Wed, 2 Dec 2020 21:41:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FFDEC996; Wed, 2 Dec 2020 21:41:48 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 350C2C988 for ; Wed, 2 Dec 2020 21:41:45 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id DAC39235; Wed, 2 Dec 2020 15:41:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 02 Dec 2020 15:41:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Qs+vR8YmEqimOHc2bkClGKzuN1nY0XuOHVFXMVHCyTg=; b=fSVumpEkFFRXTqsc eWKufFVuO0KV+POQp7R8y2RLxnHaAE/XZIm3s83zJYSw0sb13EjgEBI7Uny+Slmw ifkc9TimnOoyf2FVLALPsTcW7rp85FPwMWSnALkPo0DIudIABzFgGleKILOh3Hrc oCKk2vOPeBsjvgM2kdQejA9hRBtEaftgGlnKdBpxF1oStenaDNDGmc1ttH5xx+Kj /t2mRYpLHO1M3YJZ2xSxvEBX9WRhst2d0TgAcJtd5Wr1PzT6cWs8TbmrcyafFTKk HRJszwdSuYT/ajFKz15UXLZNaDYSLiB299DWkeubJPPSRnHaHMO6tOj+mjLC3sGX gbDkzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Qs+vR8YmEqimOHc2bkClGKzuN1nY0XuOHVFXMVHCy Tg=; b=qkWGhb7Fy/VAXq8/WUJIZLqyZ9t2zxjYuzH3PugIFcOuWNmp3NoQnYFnZ MMQMXJLVPQ8dJu71c58qthljzXsXl8mFfKK7vObsWhxyTNknQz+aysNgyw919cok JIFQoutj42/5Mny+S+J81x6KKJssob59D3a4xZg9rCaIuCm/6a6wRTIR2hsZJjbd vcdVgqhK8rd82McYgBaojEaCFmPcgREmZoxIMFQhXS1uo/32KlVNwgUal9GXprMx bCfu01oIWcqpI3lwVkD2PmKP1oq8KhOYy5IvudRE3X4e84RvYjJGLgB9chL/diyX c3UPWhs9b/HNiUkQjkdkEqxBHXwRQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeigedgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C3ED324005C; Wed, 2 Dec 2020 15:41:40 -0500 (EST) From: Thomas Monjalon To: prateekag Cc: dev@dpdk.org, Stephen Hemminger Date: Wed, 02 Dec 2020 21:41:39 +0100 Message-ID: <4079538.OZV0JHgpTk@thomas> In-Reply-To: <7271567.L1mZBfcePy@thomas> References: <77fa0d526982e5fd0a15b293599d973c@cse.iitb.ac.in> <7271567.L1mZBfcePy@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Printfs in Signal Handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/12/2020 10:24, Thomas Monjalon: > 01/12/2020 04:39, prateekag: > > printf is not signal safe and may lead to deadlock if kept in signal handler > > and > > signal comes in two quick succession. It will not lead to incorrect behavior > > and it is a highly unlikely event. And an expert may understand why this > > issue happened. Is it worthwhile to change these printfs to unix I/O write > > call? > > Thank you for reporting. > Please could you describe which files and functions you are talking about? I've received a private reply: Filenames: testpmd.c test_pmd_perf.c evt_main.c pdump/main.c Function name: signal_handler I am OK with removing these printfs. Do you want to do the patch with the explanation?