From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id A0310C3BA for ; Mon, 3 Aug 2015 18:49:29 +0200 (CEST) Received: by wicgj17 with SMTP id gj17so113901012wic.1 for ; Mon, 03 Aug 2015 09:49:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=QoWWaY1VYGLw3UGsiMs3/kukbmjaIUdYBztHXPDGcXQ=; b=WLtSUsf7KoKtxZQ5iOQ+1JMmv6zkE/R38PmLk9UNDr7bY0NQvmuDpsOfAzz8in0XN8 5Pq85AtSIRpfnBRcLgld90a3nyslZMJIAnvzdhttoG2zC/CfSYjNj916mgH7EGHpcX6U 30nwEZwYc4mkEFRxxXxV7u59c3517usx777B8mERu18976bl8+xExoldq32kMdumOoZu T59qVka+A7//k7YkE2hzPSMkrVgSwQlNsBSoHXhuNDmVY/+55OR2TnR2IUZqU7uEPPxZ QcLRzlVS0rKjXMlUXSqnNpYOdkGyysAZqmMDnMNwI9SUJE/4vfKlQS6L2B7BArU9d5/r sKlg== X-Gm-Message-State: ALoCoQkpGWFXqegEAx27V3udfyIPdGKt4AkP88fxsf7SqLsZ5FjL4eao1Qa5UFY9tLslEFh77iKD X-Received: by 10.194.6.37 with SMTP id x5mr39261073wjx.73.1438620569306; Mon, 03 Aug 2015 09:49:29 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id m4sm23717803wjb.37.2015.08.03.09.49.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 09:49:28 -0700 (PDT) From: Thomas Monjalon To: helin.zhang@intel.com Date: Mon, 03 Aug 2015 18:48:14 +0200 Message-ID: <4079988.2ivxFWYuMK@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1436422141-29024-1-git-send-email-zhe.tao@intel.com> References: <1436422141-29024-1-git-send-email-zhe.tao@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: Fix the issue when resetting the stats for i40e, the stats information will be lost before next time getting the stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 16:49:29 -0000 Helin, your review is needed. Please check how to write a simple title. 2015-07-09 14:09, Zhe Tao: > Issue: When calling the reset API to reset all the stats for i40e, > all the stats will be untracked before the next time calling get stats API. > Once calling the get stats API it will show all the stats equal zero. > > Changes: Calling the get stats API in the reset API will force the stats_offset update immediately > > Signed-off-by: Zhe Tao [...] > + > + /* > + * need to read the status one time right after reset the offset_loaded field > + * prevent the stats data loss between the i40e_dev_stats_reset and i40e_dev_stats_get > + */ This comment seems complicated to understand. > + > + i40e_dev_stats_get(dev, &stat);