DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ivan Malov <ivan.malov@oktetlabs.ru>, dev@dpdk.org
Cc: stable@dpdk.org, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Andy Moreton <amoreton@xilinx.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/sfc_efx/base: apply mask to value on match field set
Date: Tue, 19 Jan 2021 01:37:06 +0000	[thread overview]
Message-ID: <4079e230-bad2-b14f-72b2-f9ee7fb1faed@intel.com> (raw)
In-Reply-To: <20210117222112.26305-1-ivan.malov@oktetlabs.ru>

On 1/17/2021 10:21 PM, Ivan Malov wrote:
> An application may submit all-zeros masks for a given field
> to be used in two given specifications and, in the meantime,
> use different unmasked values. Later on, when compared, the
> two specifications will prove unequal, and, if the rules in
> question are outer, the client driver will have to allocate
> a separate rule for the second specification. Provided that
> all other match criteria are the same, the HW will deem the
> two outer rules being duplicates, which is in fact the case.
> Apply masks to values in efx_mae_match_spec_field_set() API
> to fix the issue and avoid duplicate outer rule allocations.
> Fixes: 370ed675a952 ("common/sfc_efx/base: support setting PPORT in match spec")
> Cc: stable@dpdk.org
> Reported-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>

Applied to dpdk-next-net/main, thanks.

      reply	other threads:[~2021-01-19  1:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-17 22:21 [dpdk-dev] " Ivan Malov
2021-01-19  1:37 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4079e230-bad2-b14f-72b2-f9ee7fb1faed@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=amoreton@xilinx.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ivan.malov@oktetlabs.ru \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).