From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
David Hunt <david.hunt@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
techboard@dpdk.org, Conor Walsh <conor.walsh@intel.com>,
John McNamara <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module
Date: Fri, 27 Nov 2020 09:55:55 +0000 [thread overview]
Message-ID: <407e05ab-7a1c-7d14-80d8-c9f613660fd8@intel.com> (raw)
In-Reply-To: <CAJFAV8wz-LC50WOh-vDRGfKN5bDK+m-Sbdu1J+BpLKU9VZtOTQ@mail.gmail.com>
On 11/26/2020 6:31 PM, David Marchand wrote:
> On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> script is checking the existing of the kernel module file, but in some
>> distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'.
>
> Since this script expects modprobe to be installed (coming with kmod
> tools), it means modinfo is available.
> Checking for module availability should be "modinfo vfio-pci".
>
+1, that is definitely better.
I can send a new version with it if we decide to keep the script.
Mainly we are tying to decide to remove the script or keep with the changes in
this set.
There aren't still much comment on it, only comment by you in favor of removal,
I haven't seen any comment to keep the script.
Added more folks for comment, also techboard comments are welcome.
next prev parent reply other threads:[~2020-11-27 9:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 14:18 [dpdk-dev] [PATCH v2 0/6] update dpdk-setup.sh Ferruh Yigit
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 1/6] usertools/setup: remove make based build Ferruh Yigit
2020-11-26 14:44 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 2/6] usertools/setup: remove inserting custom kernel modules Ferruh Yigit
2020-11-26 14:49 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 3/6] usertools/setup: remove running built applications Ferruh Yigit
2020-11-26 14:55 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 4/6] usertools/setup: remove hugepage functions Ferruh Yigit
2020-11-26 15:01 ` Walsh, Conor
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module Ferruh Yigit
2020-11-26 15:05 ` Walsh, Conor
2020-11-26 18:31 ` David Marchand
2020-11-27 9:55 ` Ferruh Yigit [this message]
2020-11-27 13:56 ` Thomas Monjalon
2020-11-27 15:29 ` Ferruh Yigit
2020-11-26 14:18 ` [dpdk-dev] [PATCH v2 6/6] usertools/setup: move removal target to 21.11 Ferruh Yigit
2020-11-26 15:13 ` Walsh, Conor
2020-11-26 16:30 ` [dpdk-dev] [PATCH v2 0/6] update dpdk-setup.sh David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407e05ab-7a1c-7d14-80d8-c9f613660fd8@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stephen@networkplumber.org \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).