From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 029D6A0524; Fri, 27 Nov 2020 10:56:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8426CC930; Fri, 27 Nov 2020 10:56:07 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 86D89C92A; Fri, 27 Nov 2020 10:56:04 +0100 (CET) IronPort-SDR: AN6hbW389iCTvWNvX6OuDU0QU566nCRmgSsiSC5YEOxeRjg5Ertx9NZUixdq9Wj4aGoQoj7T/e uiQ1R/5e1UWA== X-IronPort-AV: E=McAfee;i="6000,8403,9817"; a="172471160" X-IronPort-AV: E=Sophos;i="5.78,373,1599548400"; d="scan'208";a="172471160" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 01:56:03 -0800 IronPort-SDR: ntlFIitfHSYPnX9HqGMM4BjSj966IjNJboQkIGXNJxY2ZaASU47WowPhLZAUBdiIKMwWC6GvRI 1lDnHl+DOrsQ== X-IronPort-AV: E=Sophos;i="5.78,373,1599548400"; d="scan'208";a="479634667" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.247.181]) ([10.213.247.181]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Nov 2020 01:55:59 -0800 To: David Marchand , Bruce Richardson , Anatoly Burakov , David Hunt , Pablo de Lara , Stephen Hemminger Cc: Thomas Monjalon , dev , techboard@dpdk.org, Conor Walsh , John McNamara References: <20201126141832.2277628-1-ferruh.yigit@intel.com> <20201126141832.2277628-6-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: <407e05ab-7a1c-7d14-80d8-c9f613660fd8@intel.com> Date: Fri, 27 Nov 2020 09:55:55 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/26/2020 6:31 PM, David Marchand wrote: > On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit wrote: >> >> script is checking the existing of the kernel module file, but in some >> distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'. > > Since this script expects modprobe to be installed (coming with kmod > tools), it means modinfo is available. > Checking for module availability should be "modinfo vfio-pci". > +1, that is definitely better. I can send a new version with it if we decide to keep the script. Mainly we are tying to decide to remove the script or keep with the changes in this set. There aren't still much comment on it, only comment by you in favor of removal, I haven't seen any comment to keep the script. Added more folks for comment, also techboard comments are welcome.