From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0C70A0C43; Tue, 19 Oct 2021 11:42:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A56D940E2D; Tue, 19 Oct 2021 11:42:21 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 8E82040683 for ; Tue, 19 Oct 2021 11:42:20 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id D54D75806E2; Tue, 19 Oct 2021 05:42:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 19 Oct 2021 05:42:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= vzbm/hZYvjYpsPjO+mA9aT4QlCkStq4T9G2kZ2+Ajt8=; b=NIeg3sl1TpPqO8sm 0KRcbArzvqNXMxzM0SUCsRTLGblMevvohrC1h8bFsj+bEYdz8oEIpuAyltQLwsyC OpJm/umdSGbxNJU5siTN0raZANVtTkxqpM8+jOTkdAw4+hXeYTTeIcCc31DK+Vih 4/hUgRjaAHrrND/gAe9O7bLdjamxCDXFfw4AMaD2dbF7+woLxSwu4svRBzR7aul/ 5xo2+ijIwwXPcFvZsFH7uo2Xq74XS7NTZ6A8SKbnTe5QYDpHrTEIMgBRtocVYOZu b/n219mJCcDyEhrwLUjU+ttqv+ukHhReF5iLKynGegskBCr5vgD3f0YyIM5NnQ+y AOwThw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vzbm/hZYvjYpsPjO+mA9aT4QlCkStq4T9G2kZ2+Aj t8=; b=MwsBi8YkJS5BwBW1iqa33nRr2vwVIudQxO5xrJiQCYxkhp1jasZ/cgrOy RKLdcDbfyMuyx3SErQooy6UStHjJRm79liewCEgo+g/goKvWil2hEDPFnb3F0lC/ XbpL5CVLywtSVLp9/DYfYwyked/NQa8tXuOWc70Srh1yEfZqXJtEqXmV7pmsZXz2 4jliOnilv7+PL0tU/HPRJ2CPKmZ+k6HFKMZAFjOFl5pp0Vv0CulXB5PTyVqe607J hvIG2iXV4hqH8quv+4Jkueek8NqYS6n6T8GDqt/7X4G+0qrITxiQHMae12c3xKFa 1t1qdj0lvSDxjyy0bKi+OgejUgTmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvddvvddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Oct 2021 05:42:17 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko , David Marchand Cc: dev@dpdk.org, Olivier Matz , Ray Kinsella , "Artem V. Andreev" , Ashwin Sekhar T K , Pavan Nikhilesh , Hemant Agrawal , Sachin Saxena , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , dev Date: Tue, 19 Oct 2021 11:42:15 +0200 Message-ID: <408661365.SrHDaeAMXg@thomas> In-Reply-To: References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <86905833-5c40-76ce-3794-ec3c2e447242@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 5/6] mempool: add namespace to driver register macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/10/2021 11:27, David Marchand: > On Tue, Oct 19, 2021 at 11:05 AM Andrew Rybchenko > wrote: > > > > On 10/19/21 11:49 AM, David Marchand wrote: > > > On Mon, Oct 18, 2021 at 4:50 PM Andrew Rybchenko > > > wrote: > > >> > > >> Add RTE_ prefix to macro used to register mempool driver. > > >> The old one is still available but deprecated. > > > > > > ODP seems to use its own mempools. > > > > > > $ git grep-all -w MEMPOOL_REGISTER_OPS > > > OpenDataplane/platform/linux-generic/pktio/dpdk.c:MEMPOOL_REGISTER_OPS(odp_pool_ops); > > > > > > I'd say it counts as a driver macro. > > > If so, we could hide it in a driver-only header, along with > > > rte_mempool_register_ops getting marked as internal. > > > > > > $ git grep-all -w rte_mempool_register_ops > > > FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); > > > FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); > > > > Do I understand correctly that it is required to remove it from > > stable ABI/API, but still allow external SW to use it? > > > > Should I add one more patch to the series? > > If we want to do the full job, we need to inspect driver-only symbols > in rte_mempool.h. > But this goes way further than a simple prefixing as this series intended. > > I just read your reply, I think we agree. > Let's go with simple prefix and take a note to cleanup in the future. Yes, and we should probably discuss in techboard what should be kept compatible for external mempool drivers.