DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, stephen@networkplumber.org,
	Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/mp: remove rte_panic and profanity
Date: Fri, 26 Oct 2018 22:41:59 +0200	[thread overview]
Message-ID: <4092104.WkhJc3HfzQ@xps> (raw)
In-Reply-To: <7632620e2d7fbf772965b2d15b8187df6648a375.1540565496.git.anatoly.burakov@intel.com>

26/10/2018 16:55, Anatoly Burakov:
> --- a/lib/librte_eal/common/eal_common_proc.c
> +++ b/lib/librte_eal/common/eal_common_proc.c
> +	/*
> +	 * set the alarm before sending message. there are two possible error
> +	 * scenarios to consider here:
> +	 *
> +	 * - if the alarm set fails, we free the memory right there
> +	 * - if the alarm set succeeds but sending message fails, then the alarm
> +	 *   will trigger and clean up the memory
> +	 *
> +	 * Even if the alarm triggers too early (i.e. immediately), we're still
> +	 * holding the lock to pending requests queue, so the interrupt thread
> +	 * will just spin until we release the lock, and either release the
> +	 * memory, or doesn't find any pending requests in the queue because we
> +	 * never added any due to send message failure.
> +	 */
> +	if (rte_eal_alarm_set(ts->tv_sec * 1000000 + ts->tv_nsec / 1000,
> +			      async_reply_handle, pending_req) < 0) {
> +		RTE_LOG(ERR, EAL, "Fail to set alarm for request %s:%s\n",
> +			dst, req->name);
> +		goto fail;
> +	}

ret variable is not set and not initialized.

  reply	other threads:[~2018-10-26 20:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 18:20 [dpdk-dev] [PATCH 0/4] small cleanups Stephen Hemminger
2018-07-25 18:20 ` [dpdk-dev] [PATCH 1/4] arm: remove profanity in comment Stephen Hemminger
2018-10-24 23:50   ` Thomas Monjalon
2018-07-25 18:20 ` [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity Stephen Hemminger
2018-09-18  9:40   ` Thomas Monjalon
2018-09-18 15:07     ` Stephen Hemminger
2018-09-19 16:40       ` Mody, Rasesh
2018-10-16 14:45         ` Ferruh Yigit
2018-10-16 14:52           ` Ferruh Yigit
2018-10-26 14:56   ` Burakov, Anatoly
2018-07-25 18:20 ` [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails Stephen Hemminger
2018-07-26  9:34   ` Burakov, Anatoly
2018-07-26  9:41   ` Burakov, Anatoly
2018-09-18  9:43     ` Thomas Monjalon
2018-09-18 10:16       ` Burakov, Anatoly
2018-10-24 23:51         ` Thomas Monjalon
2018-10-25 14:04           ` Burakov, Anatoly
2018-10-26 14:55   ` [dpdk-dev] [PATCH] eal/mp: remove rte_panic and profanity Anatoly Burakov
2018-10-26 20:41     ` Thomas Monjalon [this message]
2018-10-30 10:31       ` [dpdk-dev] [dpdk-stable] " Burakov, Anatoly
2018-11-13 18:03     ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-11-13 23:03       ` Thomas Monjalon
2018-07-25 18:20 ` [dpdk-dev] [PATCH 4/4] ixgbe: remove mild profanity Stephen Hemminger
2018-10-16 15:00   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4092104.WkhJc3HfzQ@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=sthemmin@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).