* [dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL
@ 2018-01-30 15:57 Pavan Nikhilesh
2018-01-30 23:58 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Pavan Nikhilesh @ 2018-01-30 15:57 UTC (permalink / raw)
To: hemant.agrawal, olivier.matz, santosh.shukla, jerin.jacob
Cc: dev, Pavan Nikhilesh
If '--mbuf-pool-ops' is not passed to EAL as command line argument then
rte_eal_mbuf_default_mempool_ops will return NULL.
Instead check if internal_config.user_mbuf_pool_ops_name is NULL and
return compile time RTE_MBUF_DEFAULT_MEMPOOL_OPS.
Fixes: 8b0f7f43413 ("mbuf: maintain user and compile time mempool ops name")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
Currently, test/test/test_mempool_autotest is broken as it relies on
rte_eal_mbuf_default_mempool_ops().
lib/librte_eal/bsdapp/eal/eal.c | 3 +++
lib/librte_eal/linuxapp/eal/eal.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index ba1811a00..07b229fc7 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -115,6 +115,9 @@ int rte_cycles_vmware_tsc_map;
const char *
rte_eal_mbuf_default_mempool_ops(void)
{
+ if (internal_config.user_mbuf_pool_ops_name == NULL)
+ return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
+
return internal_config.user_mbuf_pool_ops_name;
}
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index 66f7585a3..ddcdb6e1f 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -125,6 +125,9 @@ int rte_cycles_vmware_tsc_map;
const char *
rte_eal_mbuf_default_mempool_ops(void)
{
+ if (internal_config.user_mbuf_pool_ops_name == NULL)
+ return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
+
return internal_config.user_mbuf_pool_ops_name;
}
--
2.16.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL
2018-01-30 15:57 [dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL Pavan Nikhilesh
@ 2018-01-30 23:58 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-01-30 23:58 UTC (permalink / raw)
To: Pavan Nikhilesh
Cc: dev, hemant.agrawal, olivier.matz, santosh.shukla, jerin.jacob
30/01/2018 16:57, Pavan Nikhilesh:
> If '--mbuf-pool-ops' is not passed to EAL as command line argument then
> rte_eal_mbuf_default_mempool_ops will return NULL.
>
> Instead check if internal_config.user_mbuf_pool_ops_name is NULL and
> return compile time RTE_MBUF_DEFAULT_MEMPOOL_OPS.
>
> Fixes: 8b0f7f43413 ("mbuf: maintain user and compile time mempool ops name")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-30 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-30 15:57 [dpdk-dev] [PATCH] eal: fix default mempool ops returning NULL Pavan Nikhilesh
2018-01-30 23:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).