From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: "Stephen Hemminger" <stephen@networkplumber.org>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
Anoob Joseph <anoobj@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Abdullah Sevincer <abdullah.sevincer@intel.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
Harry van Haaren <harry.van.haaren@intel.com>,
Ashwin Sekhar T K <asekhar@marvell.com>
Subject: Re: [RFC v2 10/10] eventdev: remove single event enqueue and dequeue
Date: Wed, 16 Oct 2024 08:20:24 +0200 [thread overview]
Message-ID: <40a329e4-d6a9-4e15-980e-33f199ced14b@lysator.liu.se> (raw)
In-Reply-To: <512b6388-bbf0-4afe-aa9f-7507f50c55a3@lysator.liu.se>
On 2024-10-16 06:36, Mattias Rönnblom wrote:
> On 2024-10-16 00:00, Stephen Hemminger wrote:
>> On Tue, 15 Oct 2024 20:25:35 +0200
>> Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:
>>
>>> Remove the single event enqueue and dequeue, since they did not
>>> provide any noticable performance benefits.
>>>
>>> This is a change of the ABI, previously announced as a deprecation
>>> notice. These functions were not directly called by the application,
>>> so the API remains unaffected.
>>>
>>> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>>
>> Still have a build failure with one driver.
>>
>
> The wonders of #ifdef <arch>.
>
I had a closer look at this, and given the elaborate macro-based
machinery and the ARM-only conditional compilation it's better if a
driver maintainer does the required changes.
(It's probably better to start from scratch on the cnxk patch, rather
than looking at anything I did.)
Ashwin Sekhar or Pavan Nikhilesh, is this something you can do?
>>
>> -------------------------------BEGIN LOGS----------------------------
>> ####################################################################################
>> #### [Begin job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build
>> and test
>> ####################################################################################
>> | ^~~~~~
>> ../drivers/event/cnxk/cn9k_eventdev.c: In function ‘cn9k_sso_fp_fns_set’:
>> ../drivers/event/cnxk/cn9k_eventdev.c:576:20: error: ‘struct
>> rte_eventdev’ has no member named ‘enqueue’; did you mean ‘ca_enqueue’?
>> 576 | event_dev->enqueue = cn9k_sso_hws_enq;
>> | ^~~~~~~
>> | ca_enqueue
>> ../drivers/event/cnxk/cn9k_eventdev.c:576:30: error:
>> ‘cn9k_sso_hws_enq’ undeclared (first use in this function); did you
>> mean ‘cn9k_sso_hws_link’?
>> 576 | event_dev->enqueue = cn9k_sso_hws_enq;
>> | ^~~~~~~~~~~~~~~~
>> | cn9k_sso_hws_link
>> ../drivers/event/cnxk/cn9k_eventdev.c:584:28: error: ‘struct
>> rte_eventdev’ has no member named ‘enqueue’; did you mean ‘ca_enqueue’?
>> 584 | event_dev->enqueue = cn9k_sso_hws_dual_enq;
>> | ^~~~~~~
>> | ca_enqueue
>> ../drivers/event/cnxk/cn9k_eventdev.c:584:38: error:
>> ‘cn9k_sso_hws_dual_enq’ undeclared (first use in this function); did
>> you mean ‘cn9k_sso_hws_dual_ca_enq’?
>> 584 | event_dev->enqueue = cn9k_sso_hws_dual_enq;
>> | ^~~~~~~~~~~~~~~~~~~~~
>> | cn9k_sso_hws_dual_ca_enq
>> [2451/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
>> sta/event_cnxk_deq_cn9k_deq_64_79_seg_burst.c.o'.
>> [2452/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
>> sta/event_cnxk_deq_cn9k_deq_80_95_seg_burst.c.o'.
>> [2453/4290] Generating rte_crypto_octeontx.sym_chk with a meson_exe.py
>> custom command.
>> [2454/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
>> sta/event_cnxk_deq_cn9k_deq_96_111_seg_burst.c.o'.
>> [2455/4290] Compiling C object 'drivers/a715181@@tmp_rte_event_cnxk at
>> sta/event_cnxk_deq_cn9k_deq_112_127_seg_burst.c.o'.
>> ninja: build stopped: subcommand failed.
>> ##[error]Process completed with exit code 1.
>> ####################################################################################
>> #### [End job log] "ubuntu-22.04-gcc-shared-aarch64" at step Build and
>> test
>> ####################################################################################
>> --------------------------------END LOGS-----------------------------
>
next prev parent reply other threads:[~2024-10-16 6:20 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 8:49 [RFC 00/10] eventdev: remove single-event " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 01/10] event/dsw: remove single event " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 00/10] eventdev: remove single-event " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 01/10] event/dsw: remove single event " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 00/10] eventdev: remove single-event " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 01/10] event/dsw: remove single event " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 02/10] event/dlb2: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 03/10] event/octeontx: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 04/10] event/sw: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 05/10] event/dpaa: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 06/10] event/dpaa2: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 07/10] event/opdl: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 08/10] event/cnxk: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 09/10] event/skeleton: " Mattias Rönnblom
2024-10-17 6:38 ` [RFC v3 10/10] eventdev: " Mattias Rönnblom
2024-10-21 7:25 ` [RFC v3 00/10] eventdev: remove single-event " Jerin Jacob
2024-10-21 8:38 ` Mattias Rönnblom
2024-10-21 8:51 ` [PATCH " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 01/10] event/dsw: remove single event " Mattias Rönnblom
2024-10-22 17:15 ` Jerin Jacob
2024-10-21 8:51 ` [PATCH 02/10] event/dlb2: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 03/10] event/octeontx: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 04/10] event/sw: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 05/10] event/dpaa: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 06/10] event/dpaa2: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 07/10] event/opdl: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 08/10] event/cnxk: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 09/10] event/skeleton: " Mattias Rönnblom
2024-10-21 8:51 ` [PATCH 10/10] eventdev: " Mattias Rönnblom
2024-10-21 9:21 ` [PATCH 00/10] eventdev: remove single-event " Mattias Rönnblom
2024-10-21 9:05 ` [PATCH 01/10] event/dsw: remove single event " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 00/10] eventdev: remove single-event " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 01/10] event/dsw: remove single event " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 02/10] event/dlb2: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 03/10] event/octeontx: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 04/10] event/sw: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 05/10] event/dpaa: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 06/10] event/dpaa2: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 07/10] event/opdl: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 08/10] event/cnxk: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 09/10] event/skeleton: " Mattias Rönnblom
2024-10-21 9:06 ` [PATCH 10/10] eventdev: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 02/10] event/dlb2: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 03/10] event/cnxk: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 04/10] event/octeontx: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 05/10] event/sw: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 06/10] event/dpaa: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 07/10] event/dpaa2: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 08/10] event/opdl: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 09/10] event/skeleton: " Mattias Rönnblom
2024-10-15 18:25 ` [RFC v2 10/10] eventdev: " Mattias Rönnblom
2024-10-15 22:00 ` Stephen Hemminger
2024-10-16 4:36 ` Mattias Rönnblom
2024-10-16 6:20 ` Mattias Rönnblom [this message]
2024-10-16 14:14 ` Jerin Jacob
2024-10-15 8:49 ` [RFC 02/10] event/dlb2: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 03/10] event/cnxk: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 04/10] event/octeontx: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 05/10] event/sw: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 06/10] event/dpaa: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 07/10] event/dpaa2: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 08/10] event/opdl: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 09/10] event/skeleton: " Mattias Rönnblom
2024-10-15 8:49 ` [RFC 10/10] eventdev: " Mattias Rönnblom
2024-10-15 17:07 ` [RFC 00/10] eventdev: remove single-event " Stephen Hemminger
2024-10-15 18:38 ` Mattias Rönnblom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a329e4-d6a9-4e15-980e-33f199ced14b@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=abdullah.sevincer@intel.com \
--cc=anoobj@marvell.com \
--cc=asekhar@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=pbhagavatula@marvell.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=stephen@networkplumber.org \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).