Re: [dpdk-dev] [PATCH v2 0/8] common/sfc_efx: prepare to introduce vDPA driver

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

On 3/15/21 6:54 PM, Ferruh Yigit wrote:
> On 3/15/2021 1:58 PM, Andrew Rybchenko wrote:
>> Update base driver to provide functionality required by vDPA driver.
>>
>> Factor out helper functions to be shared by net and vDPA drivers.
>>
>> v2:
>>   - fix windows build breakage - do not build common/sfc_efx in the case
>>     of windows
>>   - remove undefined efx_virtio_* functions from version.map (since
>>     EFSYS_OPT_VIRTIO is disabled)
>>
>> Vijay Kumar Srivastava (6):
>>    common/sfc_efx/base: add virtio build dependency
>>    common/sfc_efx/base: add support to get virtio features
>>    common/sfc_efx/base: add support to verify virtio features
>>    common/sfc_efx: add support to get the device class
>>    net/sfc: skip driver probe for incompatible device class
>>    drivers: add common driver API to get efx family
>>
>> Vijay Srivastava (2):
>>    common/sfc_efx/base: add base virtio support for vDPA
>>    common/sfc_efx/base: add API to get VirtQ doorbell offset
>>
>
> build still fails for windows,
> http://mails.dpdk.org/archives/test-report/2021-March/182539.html
>
> I guess it is missing, "build=false":
>   if is_windows
>  +       build=false
>          subdir_done()
>   endif
>

Looks like fixed in v3. At least Intel compilation test is OK now.

Thanks,
Andrew.