From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3EC1DA054F;
	Tue, 16 Mar 2021 08:25:56 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 03C4A4069F;
	Tue, 16 Mar 2021 08:25:56 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 19F6440042
 for <dev@dpdk.org>; Tue, 16 Mar 2021 08:25:55 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B473A7F528;
 Tue, 16 Mar 2021 10:25:54 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B473A7F528
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1615879554;
 bh=NddJzmALrAAw0Gh/ebaUZZfiArQlvNlbQAmrJj9z62A=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=FosKlWMkMbFJIS4dgvjwWKlh85YxKFM4RhiktWXlTcEH0Eo+0tE6GM86OvDIFBhoU
 AHwhqMFGT1FYILNQEILpOUzx+bFrmTFr7MnjRvn1xifBxuVzV7tslOZsZaEbCjbrhd
 mQl7RRfgL5XIUB3bKQsM0/FI7EUMs1g67cL1nwvQ=
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
References: <20210311110325.3291203-1-andrew.rybchenko@oktetlabs.ru>
 <20210315135823.605774-1-andrew.rybchenko@oktetlabs.ru>
 <fa4b1c09-8f7e-201a-db8c-bdd5d087803a@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <40ae4f15-d639-3686-a52b-10ee702dea70@oktetlabs.ru>
Date: Tue, 16 Mar 2021 10:25:54 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <fa4b1c09-8f7e-201a-db8c-bdd5d087803a@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v2 0/8] common/sfc_efx: prepare to introduce
 vDPA driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/15/21 6:54 PM, Ferruh Yigit wrote:
> On 3/15/2021 1:58 PM, Andrew Rybchenko wrote:
>> Update base driver to provide functionality required by vDPA driver.
>>
>> Factor out helper functions to be shared by net and vDPA drivers.
>>
>> v2:
>>   - fix windows build breakage - do not build common/sfc_efx in the case
>>     of windows
>>   - remove undefined efx_virtio_* functions from version.map (since
>>     EFSYS_OPT_VIRTIO is disabled)
>>
>> Vijay Kumar Srivastava (6):
>>    common/sfc_efx/base: add virtio build dependency
>>    common/sfc_efx/base: add support to get virtio features
>>    common/sfc_efx/base: add support to verify virtio features
>>    common/sfc_efx: add support to get the device class
>>    net/sfc: skip driver probe for incompatible device class
>>    drivers: add common driver API to get efx family
>>
>> Vijay Srivastava (2):
>>    common/sfc_efx/base: add base virtio support for vDPA
>>    common/sfc_efx/base: add API to get VirtQ doorbell offset
>>
>
> build still fails for windows,
> http://mails.dpdk.org/archives/test-report/2021-March/182539.html
>
> I guess it is missing, "build=false":
>   if is_windows
>  +       build=false
>          subdir_done()
>   endif
>

Looks like fixed in v3. At least Intel compilation test is OK now.

Thanks,
Andrew.