From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1E4FA0546; Thu, 16 Jul 2020 09:34:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5E7D1BE9C; Thu, 16 Jul 2020 09:34:18 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id E23783421 for ; Thu, 16 Jul 2020 09:34:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594884857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7qyGEmWsq7eVEBTMhZggeTISZ/rogs/MniYCNDsn92w=; b=OHYDsZezVwfro5AaHDvYQJsnesjfkbDb6O+LXGebflEOIQPY8vsEgFvdVRtKzd4pajVCQZ r+TDKcNGvHDG7CuuRsU5SlqqkfXkwFUw93N5ASuUSrFDrs/QdGctlw4iexd2jv6NPGoWPg Qgu3TB/+RQ3KEKLCgVaxDRUVfyhFInI= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-YzzApLCOOayPPRA0-X19PA-1; Thu, 16 Jul 2020 03:34:16 -0400 X-MC-Unique: YzzApLCOOayPPRA0-X19PA-1 Received: by mail-wm1-f72.google.com with SMTP id 65so4435278wmd.8 for ; Thu, 16 Jul 2020 00:34:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7qyGEmWsq7eVEBTMhZggeTISZ/rogs/MniYCNDsn92w=; b=hPtTmUEdVXQjxh1N15LoeloV4ptODEMJgp9ScU4h9Zht7J8VDSGxiNF6kbXNnudnz8 rmTgKCsIsWXK31iaEvwrBjcL6sXTMcWRw8o9KmGl77xhtC7febfhLwuwxVgDaAfl0+38 KR4tQgHAlXUTtBKjP2c/BcP5YAvrUX1ClXG3My2bExP6WWUR5lUHn6E9Yivx4MmkhTvY VeYIYxO8NAjsWfQaTXxWVfaXsK6P2PsEr+hle2e3tZP7GT++wdSSUIDpuRb7LkfQXh4N PuO/+Ho2lFqA/zX0fzrVRlbuN2yLB2lT4U0DLj/0EG+HfazaoLQjeyceaLEAryyTVX8v eF7Q== X-Gm-Message-State: AOAM531+ECZNpGzVDASnZDcL+P3B/84+YvXksdhxwJTqFIpsvgdKD8L/ 4s/fdNouGef56QS+eB/RT6l0lxNNCeUUBapt24sg5UyGE1tEAQCjk7ZK0ZjywqHD1Y3UD7/sLM8 oirY= X-Received: by 2002:adf:b190:: with SMTP id q16mr3746172wra.356.1594884854844; Thu, 16 Jul 2020 00:34:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxn5qNaoSedL+twwbEqgtK/lNNW1CXX7zhWFMZ27HtlL3An87dizNCzGN5OH/9ActSl3cmuZg== X-Received: by 2002:adf:b190:: with SMTP id q16mr3746145wra.356.1594884854524; Thu, 16 Jul 2020 00:34:14 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([92.176.159.3]) by smtp.gmail.com with ESMTPSA id 65sm9326857wre.6.2020.07.16.00.34.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2020 00:34:13 -0700 (PDT) To: "Xia, Chenbo" , "dev@dpdk.org" Cc: "maxime.coquelin@redhat.com" , "Wang, Zhihong" , "Li, Miao" References: <20200715171828.95887-1-amorenoz@redhat.com> <20200715171828.95887-3-amorenoz@redhat.com> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: <40eae877-1b4a-2eb4-52d5-de115b2811e1@redhat.com> Date: Thu, 16 Jul 2020 09:34:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, On 7/16/20 4:26 AM, Xia, Chenbo wrote: > Hi Adrian, > >> -----Original Message----- >> From: Adrian Moreno >> Sent: Thursday, July 16, 2020 1:18 AM >> To: dev@dpdk.org >> Cc: maxime.coquelin@redhat.com; Wang, Zhihong ; >> amorenoz@redhat.com; Xia, Chenbo >> Subject: [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit >> >> For the sake of completeness, add the definition of the missing status bit in >> accordance with the virtio spec >> >> Signed-off-by: Adrian Moreno >> --- >> drivers/net/virtio/virtio_pci.h | 13 +++++++------ >> 1 file changed, 7 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h index >> 74ed77e33..ab61e911b 100644 >> --- a/drivers/net/virtio/virtio_pci.h >> +++ b/drivers/net/virtio/virtio_pci.h >> @@ -57,12 +57,13 @@ struct virtnet_ctl; >> #define VIRTIO_ID_9P 0x09 >> >> /* Status byte for guest to report progress. */ >> -#define VIRTIO_CONFIG_STATUS_RESET 0x00 >> -#define VIRTIO_CONFIG_STATUS_ACK 0x01 >> -#define VIRTIO_CONFIG_STATUS_DRIVER 0x02 >> -#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04 -#define >> VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08 >> -#define VIRTIO_CONFIG_STATUS_FAILED 0x80 >> +#define VIRTIO_CONFIG_STATUS_RESET 0x00 >> +#define VIRTIO_CONFIG_STATUS_ACK 0x01 >> +#define VIRTIO_CONFIG_STATUS_DRIVER 0x02 >> +#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04 >> +#define VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08 >> +#define VIRTIO_CONFIG_STATUS_DEV_NEED_RESET 0x40 >> +#define VIRTIO_CONFIG_STATUS_FAILED 0x80 > > Do we need to delete ' VIRTIO_CONFIG_STATUS_RESET'? I see vhost lib does not > have it now. And I read virtio 1.1 spec and find the description of writing 0 to > reset device is deleted. I think virtio 1.1 spec is not very clear about reset status. > Does 'DEV_NEED_RESET' equal old 'RESET'? > In virtio 1.1 "2.1.2 Device Requirements: Device Status Field The device MUST initialize device status to 0 upon reset. ... " So I think having "#define VIRTIO_CONFIG_STATUS_RESET 0x00" is still useful to understand what is going on in: void vtpci_reset(struct virtio_hw *hw) { VTPCI_OPS(hw)->set_status(hw, VIRTIO_CONFIG_STATUS_RESET); /* flush status write */ VTPCI_OPS(hw)->get_status(hw); } DEV_NEED_RESET is used for the device to notify that it has encountered an unrecoverable error. Therefore, the driver would never "set_status(VIRTIO_CONFIG_STATUS_DEV_NEED_RESET)"; instead, it should read the status and if this bit is set, reset the device. > Thanks! > Chenbo > >> >> /* >> * Each virtqueue indirect descriptor list must be physically contiguous. >> -- >> 2.26.2 > -- Adrián Moreno