From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6ECE6A0C3F; Thu, 15 Apr 2021 14:34:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB86A16225D; Thu, 15 Apr 2021 14:34:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 3C427162257 for ; Thu, 15 Apr 2021 14:34:00 +0200 (CEST) IronPort-SDR: r46v5kL3+99lXcPnNb6blvlU3WO7d4HPGV5quxuXIKMYLWYII1jVXrN6qiJMpNOb6az7tBxRcv 0dsNlgpQha0A== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="181965648" X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="181965648" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 05:33:13 -0700 IronPort-SDR: owiaGERGPT3FeljyhyYo4qZpAEOkKfu54OCY8cgFt1tfNcHIk7/6bnOFDYY8ptfA1A9/shLJCa p9zW/EHXyyng== X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="384006351" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.163]) ([10.213.204.163]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 05:33:09 -0700 To: Lijun Ou , thomas@monjalon.net, Ray Kinsella , David Marchand Cc: dev@dpdk.org, linuxarm@openeuler.org, Andrew Rybchenko References: <1616670560-62333-1-git-send-email-oulijun@huawei.com> <1618454426-21457-1-git-send-email-oulijun@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <41261214-284c-3f66-a5c7-14bbe0df65b0@intel.com> Date: Thu, 15 Apr 2021 13:33:05 +0100 MIME-Version: 1.0 In-Reply-To: <1618454426-21457-1-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V3] ethdev: add queue state when retrieve queue information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/15/2021 3:40 AM, Lijun Ou wrote: > Currently, upper-layer application could get queue state only > through pointers such as dev->data->tx_queue_state[queue_id], > this is not the recommended way to access it. So this patch > add get queue state when call rte_eth_rx_queue_info_get and > rte_eth_tx_queue_info_get API. > > Note: After add queue_state field, the 'struct rte_eth_rxq_info' size > remains 128B, and the 'struct rte_eth_txq_info' size remains 64B, so > it could be ABI compatible. > > Signed-off-by: Chengwen Feng > Signed-off-by: Lijun Ou Looks good to me, but it is causing an ABI error as we already discussed before as that is false positive. Ray, David, Should we add any exception to libabigail.abignore for this?