From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 8EE97902 for ; Fri, 26 Feb 2016 10:07:52 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id c200so63223446wme.0 for ; Fri, 26 Feb 2016 01:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=yArJK455qG7pCslNIFpTOVL0FXccY99rxfouA0kp1sE=; b=ocBHsYCPXc57R7p8JqXNQRGOr2eSiuJgeVMXnkWcEYl+wnmbZz0IB2mwzFoMfwT7+9 6SIP0jS1z18Yb9xDh7wPh+Q+sPZSuT/N9JndrcYtFwgp0BPShyke5xB3skE3gNe3tQ7+ 0Gxo0hoXKIjZp/TtxGlDRm3ljcuaMWDdA5Ajh7stu+QmSygXpALgVvZSgoXxH7eBRM3f wtdDiMJkANV2WFB7JTi/wkRd8W+DACpuLAbk8CQZP+N0gBK1QPrWPF0obCai2o/t/5QY MbGWNOQxmkP/Iz3mz2CP4Jpx639w25xVZuds9sy+33a/yPgeXnJK8JIBYmbufirKEC9W YLeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=yArJK455qG7pCslNIFpTOVL0FXccY99rxfouA0kp1sE=; b=ms+mpuDlqPQtwPaDyA6HboA3ZMzN81IdjO5OSNTKhWjdPLpVNHGF5+IA9zUwq9y0fz 9PoN4wEpgseV0hac01DRoC9q/aLaShtmzawFC+E2Adlem3pqjq2Hia/rJ9IollTjlaEh 5jb+9E5+WAWm/5hpqTYzAYk4jLPFXpxbYt+ZYxJBp1dJp+FWRh3jlKW7bA4281pKS7u/ LYjBqwSLkNpEMZVJUTzg3v3JLElNR1or/DxHgkmeunwhTaoukQJgyVIPM1//Hwt8zxtK EMJtzoJPLmdAHi/ftcsdK+xQSTFK8hV65GmhKz8QNbAQMMr6W+XIvgsmxV/agkiT6U6F ckOA== X-Gm-Message-State: AD7BkJJPJZZ1Wx4+8OMNsodlLOaWtHfCXnTo9eOl2D/zTGgvpIk2htdrx6qn3g/BeJ7XATO6 X-Received: by 10.194.188.20 with SMTP id fw20mr615838wjc.80.1456477672447; Fri, 26 Feb 2016 01:07:52 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id c26sm1915421wmi.24.2016.02.26.01.07.51 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Feb 2016 01:07:51 -0800 (PST) From: Thomas Monjalon To: "Wang, Xiao W" Date: Fri, 26 Feb 2016 10:06:18 +0100 Message-ID: <4126401.C51dJZWCEs@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1454410216-13333-2-git-send-email-xiao.w.wang@intel.com> <20160225161406.GA22772@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 1/3] fm10k: enable FTAG based forwarding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2016 09:07:52 -0000 2016-02-26 04:31, Wang, Xiao W: > From: Richardson, Bruce > > On Thu, Feb 25, 2016 at 03:45:45PM +0000, Chen, Jing D wrote: > > > From: Richardson, Bruce > > > > On Thu, Feb 25, 2016 at 10:04:02AM +0000, Chen, Jing D wrote: > > > > > This feature is trying to use FTAG (a unique tech in fm10k) > > > > > instead of mac/vlan to forward packets. App need a way to tell PMD > > > > > driver that which forwarding style it would like to use. > > > > > > > > Why not just specify this in the port configuration at setup time? > > > > > > > > > > Please educate me. I think the port configuration flags are also > > > common to all PMD Drivers. Is it possible to add a flag like "RTE_USE_FTAG" > > and pass to PMD driver? > > > > > They are. > > For something PMD specific, like FTAG, it's always a challenge, and I don't > > know off the top of my head if there is a simple option. However, given the > > choice between an mbuf flag and a port config flag, I'd always choose the > > former. > > Other alternatives would be to have a fm10k specific API in the fm10k driver > > alone. > > > > I'll let Thomas as ethdev maintainer comment if he has other suggestions as to > > how to handle this case. I suspect this won't be the first device-specific piece of > > functionality we need to deal with. > > > > /Bruce > > Whatever method we choose, we have to find a way for the user to express his need > for FTAG, it maybe a build time config option, or a port config flag (no such flag now), > or a fast path flag in mbuf (no such flag now) etc. For the customer Topsec's use case, > they use FTAG for all the TX packets, so all the above methods (per build config, per > port config, per mbuf config) can meet their need. Since the pmd frame work is for > common, it's hard to add new fields only for one specific NIC, so I add a build time > config and make an introduction in the doc. > > Thanks for the discussion, Thomas, do you have any suggestions? I don't understand why you say this feature is specific to fm10k. Can we imagine another NIC having this capability? I think it must be an port configuration, as Bruce suggested. What about a field in struct rte_eth_conf?