From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA2FAA0351; Sat, 26 Feb 2022 14:32:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6ED74068F; Sat, 26 Feb 2022 14:32:03 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id E627540395 for <dev@dpdk.org>; Sat, 26 Feb 2022 14:32:01 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 258A85C0139; Sat, 26 Feb 2022 08:32:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 26 Feb 2022 08:32:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=zwqDtSt5DbfJSP 66cd8oeOXtv4jWfglx+HdhJ4jsIR4=; b=RAWzHpQ6edB1EmWP9Kwkmx/XGWuuZg o7xs0al0KjCG5KJ60TmOreQy60ehB8eyrpf68fmwXgkpTdxOCKukpb8PdQg/bJqP dP0f3k6rJb/eGbV2XLM25vDW/fwgzmSaDUgiqysAoG8UpMJHVTxG4ZlJgYza/yZw kSbqD6dGHb4Nj1M9AnbvA6SvI4O/7Wmz7+g+e2f8JnPCSB9zY+aMagIN8AjUh/rJ rbaBXK09o/Bf/mXUdbO/dA6M3TNNWG7jSlv4j6dznX7WuNFoRbmzt8MhlVzwgD+H NN4bY7BwZVF3dBpf3zU+LVlQUeqWYblIiBOc4nI648kI2SvaED6ckV9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zwqDtSt5DbfJSP66cd8oeOXtv4jWfglx+HdhJ4jsI R4=; b=hZoNCzWQcot71ZMXxwT1WvWfXxSphWN4as17/f3w33DCDNkrJ9+n2Xppn 0lA+6EnwtvjFBzncwGLBDIBd0zMiWD0BhbYk5zro8ZtcfFTrTBqXlQrnXd24p9aj vM0ZejH2A+xs3iJA2mUVX+uZKqRhzUB0awmG4oX4E5GZrZpNuNRfKCQjAKuAUEXv B0xgYGvR6iOAVncT7wZ51iiL041PLDRs05WNbC2DxT/9CJhbNakMn/hhAtQx18em 5Rvv2ns2nNBjv4WjmHk4hAQADfjKC1r54L+Ilu3E0hWk35AP9cFk+2UWK39O7BQA aADveapFkv3+QC3hhhsV2tGqNQ3VQ== X-ME-Sender: <xms:zysaYpvh-PHecTFUMQugnAztKjnuzI3gyWRRCBX4gAyvPNnBQb3FVg> <xme:zysaYidtg05dSutbM6kQ9RRlmeKUSslE413mJwOfno3-bq1TBVuLF_RmjPNUqg9U6 fxHyYkaidb-9_TCtg> X-ME-Received: <xmr:zysaYszbWuvNgLvQujBcVuafP6nuHdsaHcqaYbCcDA84-CSw-3fyix5O9s1WhLOJMzalBRpyWJnn0QgpeLHw1YQ99w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleeigdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:zysaYgNKHKQ-w5cq-7-my-4IncTly_aDxyw9H1tRKafIS_s8mgDLpA> <xmx:zysaYp_5kVsVWiaynVjeOJp32qEvrXBy5PHgVMkeEy9bNr5EYbaQ_Q> <xmx:zysaYgW_5qToinzo2GgQr4SzXx0XOGxL7yEHEmhn_tSVWcoLU8-z-w> <xmx:0CsaYpzjnWeOs16wU99eCBSPPj49nCt25gWYsG84Ef8JB5kx-s5F8Q> Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Feb 2022 08:31:58 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Jerin Jacob <jerinjacobk@gmail.com> Cc: dev@dpdk.org, Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>, ferruh.yigit@intel.com Subject: Re: [PATCH v2 21/21] doc: add table for environment variables used by cnxk Date: Sat, 26 Feb 2022 14:31:56 +0100 Message-ID: <4127090.mogB4TqSGs@thomas> In-Reply-To: <CALBAE1M=iD=0J5G0SKKCTgD9g+00cYxsvU+qGVjspsSoLSC=fA@mail.gmail.com> References: <20220207072932.22409-1-ndabilpuram@marvell.com> <1758600.8hzESeGDPO@thomas> <CALBAE1M=iD=0J5G0SKKCTgD9g+00cYxsvU+qGVjspsSoLSC=fA@mail.gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 26/02/2022 10:37, Jerin Jacob: > On Sat, Feb 26, 2022 at 2:52 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > > 22/02/2022 20:35, Nithin Dabilpuram: > > > Add table for environment variables used by cnxk drivers. > > > > > > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com> > > > --- > > > +.. table:: cnxk environment variables > > > + > > > + +---+-----------------------------+-----------------------------------------+ > > > + | # | Variable name | Usage | > > > + +===+=============================+=========================================+ > > > + | 1 | BPHY_INTR_MLOCK_DISABLE | When defined disables memory locking in | > > > + | | | BPHY environment. | > > > + +---+-----------------------------+-----------------------------------------+ > > > + | 2 | ROC_CN10K_MBOX_TIMEOUT | When set, overrides MBOX timeout by | > > > + | | ROC_MBOX_TIMEOUT | value in milli seconds. | > > > + +---+-----------------------------+-----------------------------------------+ > > > + | 3 | CN10K_ETH_SEC_IV_OVR | When set, overrides outbound inline SA | > > > + | | | IV in CN10K. By default IV is generated | > > > + | | | by HW. Format of variable is string | > > > + | | | of comma separated one byte values as | > > > + | | | for ex: "0x0, 0x10, 0x20, ..." | > > > + +---+-----------------------------+-----------------------------------------+ > > > > Using tables for such list is a bad idea. > > The source code is constrained in a small column, > > and the HTML rendering is constrained by the page width. > > I recommend switching to the definition list syntax > > which has a nice rendering for such definitions. > > > > Example: > > ``BPHY_INTR_MLOCK_DISABLE`` > > Disable memory locking in BPHY environment. > > Sure, You can remove this doc update while merging to the main tree. > We will submit a separate patch for updating this document > based on your suggestion. It has been squashed in a commit adding the third variable, so yes it can be dropped and submitted again for the 3 variables.