From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17AE9A04DD; Thu, 26 Nov 2020 18:56:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF794CA18; Thu, 26 Nov 2020 18:56:26 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 26A81CA0A for ; Thu, 26 Nov 2020 18:56:25 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id CA4F95C011A; Thu, 26 Nov 2020 12:56:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 26 Nov 2020 12:56:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= EcN6h4JG0+TwMSIsk1VoB5CMF2O5MM74TS7YXezp3iE=; b=Ozb3rpXZFF1HyKtw Oia5SvwAygLhlgFNFQ29y4OABEKsEOCFWOsTdyjZdeeMtEWrVV8hD7hKo9bW8IVR XW7pKnR/c03I2z1BUXdnf3u2zsyEKNJf0Pe5FqEDbEz8bCzq0XFxanXtkjKEFgND MOymgLItFsHTWG33xRYvy/Szb2sG5aTy5SjxWqS2nV9/HoxYVCA25JMbNBYT9qOL kvWfPIbxPlIJ6DKI7whenDFxR+Wmc5QxbQkTpfqOyGccU8HYAja+Lq8WyD9SVEm3 70wncmy5Wy6gpv9pPHfLuWSqdyhAEsXmWimLrVAcQLSehqvIgOpL3hMQXg4u6sfE UZk1mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EcN6h4JG0+TwMSIsk1VoB5CMF2O5MM74TS7YXezp3 iE=; b=csFzXl+Ki1VAxAUu+hB9Ol9DGUJYod85txb2wVJ7CydBTszdyPG8v2GlA TtdhiTnazZKw1R81/6kc/r87xqNpbTPmt7fm8zd2z4cScrWdi8vqIja9QkOlFJKq X62WCJsX0p2iUVOmMeTjB4nSeL26lyv3cPF9KiT9tz9Jvksajrh1jL7v8y5Y4iII YllL2q3/twZOO9nhArGrGJmfSpjTFbN6pNAmDVuBEVZPV9eZYf8Ld5XbIbTX1Z6/ 85SnmhMeeWnVQ/ErRHEpPKFvIgwlfeNcp2oPzTg4KTbo+6XGh7tUISU1wEtJ0WrI JYDcwaIdm+flZ7oFYyfl8OVGzkRSg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehvddguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6ACAC3280065; Thu, 26 Nov 2020 12:56:22 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger , Yipeng Wang , honnappa.nagarahalli@arm.com Cc: dev@dpdk.org, Sameh Gobriel , Bruce Richardson , pablo.de.lara.guarch@intel.com Date: Thu, 26 Nov 2020 18:56:21 +0100 Message-ID: <4130571.hpL29E20KA@thomas> In-Reply-To: <1609609.4PBobdEyhI@thomas> References: <20200604171731.6738-1-stephen@networkplumber.org> <20200605113508.746ba6b2@hermes.lan> <1609609.4PBobdEyhI@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/06/2020 18:12, Thomas Monjalon: > 05/06/2020 20:35, Stephen Hemminger: > > On Thu, 4 Jun 2020 10:17:31 -0700 > > Stephen Hemminger wrote: > > > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > > operations are called from a non-EAL thread. > > > > > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL > > > thread and that leads to using wrong local cache. > > > > > > Add error checks and document the restriction. > > > > > > Fixes: 9d033dac7d7c ("hash: support no free on delete") > > > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") > > > Signed-off-by: Stephen Hemminger > > > Cc: honnappa.nagarahalli@arm.com > > > Cc: pablo.de.lara.guarch@intel.com > > > > This restriction also needs to be added to the known issues > > section of EAL > > Are you going to send a v2 adding doc? Any follow-up?