From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76DD7A0C46; Fri, 23 Jul 2021 11:43:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1032840040; Fri, 23 Jul 2021 11:43:44 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 71F634003C for ; Fri, 23 Jul 2021 11:43:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1D47F5C00E4; Fri, 23 Jul 2021 05:43:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 23 Jul 2021 05:43:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= VoBBB1Vo66DyZi0r23el2KP5J78MeHPE2w/TlX/S35g=; b=p3IPpZoGpM8qGTS2 XbIUP0Qz7Y7dIx0KriyMg0ZJdp6ncoHjnE7o8/m33ySz7yPo1uaxb5Cl4vOxzFqF nhAEzqk4dBlNreijq4c0v/91tVCsj4ky4rECfW0GDZKp383U5sH49neq4O3ECjp8 YpAkEeBhpSJggnOGxUtMzefO4S9jQnjM6TsEe8B3lpqvLcroSoxRcO+vnBrzv0Z2 ezPDwxws5O5fpS92NH5w9DscPMwminAa7bUe+Bhv0tIASMkIS4hkikdhIA4Y/AvL 16ruukO/grWxRUOkv1nWkA3C4AZU7UW7Hi6HBJoTGVowSNZj5OxIRRfg7jxnZ+MA js36eA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=VoBBB1Vo66DyZi0r23el2KP5J78MeHPE2w/TlX/S3 5g=; b=HmQ06lbO+V431+WmsoFhG1BZeR7njZzG9019JmSaOA1GhlUQUF91BVUhM cu7DhDGdLgb93pIhkvT7dXlpGc8yiMa4UUEakADgW1qKkizXk4LxWnh+RLKq1CuP GLup4gKoKTdWvT7mUixZCDwMJ8hPxX6LyesOZ32/tlVJR09PP/KJpFfLSJ/eKJja O2kO0qrGiTk9CX6smIpoN6FzFzSfoxDFd7Uvq6GMf6RPIKAhRiBxdaQat1IbTJ1c j6lBCVOXIqVDodfBNhMVBcTgsiVy+gIcSW2mSXvVP2eHRGvUHXuOSgj7Ln8PWAkK RIblQZoFJQtj8ShKOloJ3Omv+Na7A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 05:43:40 -0400 (EDT) From: Thomas Monjalon To: =?utf-8?B?TWljaGHFgg==?= Krawczyk Cc: dev , "Dagan, Noam" , "Brandes, Shai" , upstream@semihalf.com, Shay Agroskin , Amit Bernstein , Ferruh Yigit , David Marchand Date: Fri, 23 Jul 2021 11:44:01 +0200 Message-ID: <4131521.qjy5Xc5Wae@thomas> In-Reply-To: References: <20210714103435.3388-1-mk@semihalf.com> <1691540.9AlFL3h5L8@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2021 11:39, Micha=C5=82 Krawczyk: > pt., 23 lip 2021 o 11:22 Thomas Monjalon napisa=C5= =82(a): > > > > 14/07/2021 12:43, Michal Krawczyk: > > > + PMD_DRV_LOG(WARNING, > > > + "Setting RSS hash fields is not supported. Us= ing default values: 0x%llx\n", > > > + ENA_ALL_RSS_HF); > > > > > > > checkpatch is returning this warning: > > Using %l format, prefer %PRI*64 if type is [u]int64_t > > > > Indeed rss_hf is uint64_t. > > > > >=20 > Hi Thomas, >=20 > I'm aware of that checkpatch warning, but changing format to %PRIx64 > results in another (compilation) warning: >=20 > [1205/2572] Compiling C object > drivers/libtmp_rte_net_ena.a.p/net_ena_ena_rss.c.o > In file included from ../drivers/net/ena/ena_rss.c:7: > ../drivers/net/ena/ena_rss.c: In function =E2=80=98ena_rss_hash_set=E2=80= =99: > ../drivers/net/ena/ena_logs.h:35:3: warning: format =E2=80=98%lx=E2=80=99= expects > argument of type =E2=80=98long unsigned int=E2=80=99, but argument 5 has = type =E2=80=98long > long unsigned int=E2=80=99 [-Wformat=3D] > 35 | "%s(): " fmt, __func__, ## args) > | ^~~~~~~~ > ../drivers/net/ena/ena_rss.c:427:3: note: in expansion of macro =E2=80=98= PMD_DRV_LOG=E2=80=99 > 427 | PMD_DRV_LOG(WARNING, > | ^~~~~~~~~~~ > In file included from ../lib/mempool/rte_mempool.h:40, > from ../lib/mbuf/rte_mbuf.h:38, > from ../lib/net/rte_ether.h:23, > from ../drivers/net/ena/ena_ethdev.h:10, > from ../drivers/net/ena/ena_rss.c:6: > /usr/include/inttypes.h:121:34: note: format string is defined here > 121 | # define PRIx64 __PRI64_PREFIX "x" Sorry I don't have time to dig, but I'm sure you can fix it.