DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce change in ETH item struct
@ 2020-08-04 16:01 Dekel Peled
  2020-08-05  3:39 ` Ajit Khaparde
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Dekel Peled @ 2020-08-04 16:01 UTC (permalink / raw)
  To: dev
  Cc: jerinjacobk, stephen, arybchenko, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, asafp

Struct rte_flow_item_eth will be modified to include additional
values, indicating existence or absence of VLAN headers following
the ETH header, as proposed in RFC
https://mails.dpdk.org/archives/dev/2020-August/177349.html.
Because of ABI break this change is proposed for 20.11.

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 5201142..6241709 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -115,6 +115,11 @@ Deprecation Notices
   following the IPv6 header, as proposed in RFC
   https://mails.dpdk.org/archives/dev/2020-August/177257.html.
 
+* ethdev: The ``struct rte_flow_item_eth`` struct will be modified to include
+  additional values, indicating existence or absence of VLAN headers
+  following the ETH header, as proposed in RFC
+  https://mails.dpdk.org/archives/dev/2020-August/177349.html.
+
 * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly made
   ABI stable in the v19.11 release. The TM maintainer and other contributors have
   agreed to keep the TM APIs as experimental in expectation of additional spec
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
  2020-08-04 16:01 [dpdk-dev] [PATCH] doc: announce change in ETH item struct Dekel Peled
@ 2020-08-05  3:39 ` Ajit Khaparde
  2020-08-05 10:49 ` Andrew Rybchenko
  2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
  2 siblings, 0 replies; 12+ messages in thread
From: Ajit Khaparde @ 2020-08-05  3:39 UTC (permalink / raw)
  To: Dekel Peled
  Cc: dpdk-dev, Jerin Jacob, Stephen Hemminger, Andrew Rybchenko,
	maxime.coquelin, Olivier Matz, David Marchand, Ferruh Yigit,
	Asaf Penso

On Tue, Aug 4, 2020 at 9:07 AM Dekel Peled <dekelp@mellanox.com> wrote:

> Struct rte_flow_item_eth will be modified to include additional
> values, indicating existence or absence of VLAN headers following
> the ETH header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177349.html.
> Because of ABI break this change is proposed for 20.11.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>


> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 5201142..6241709 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -115,6 +115,11 @@ Deprecation Notices
>    following the IPv6 header, as proposed in RFC
>    https://mails.dpdk.org/archives/dev/2020-August/177257.html.
>
> +* ethdev: The ``struct rte_flow_item_eth`` struct will be modified to
> include
> +  additional values, indicating existence or absence of VLAN headers
> +  following the ETH header, as proposed in RFC
> +  https://mails.dpdk.org/archives/dev/2020-August/177349.html.
> +
>  * traffic manager: All traffic manager API's in ``rte_tm.h`` were
> mistakenly made
>    ABI stable in the v19.11 release. The TM maintainer and other
> contributors have
>    agreed to keep the TM APIs as experimental in expectation of additional
> spec
> --
> 1.8.3.1
>
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
  2020-08-04 16:01 [dpdk-dev] [PATCH] doc: announce change in ETH item struct Dekel Peled
  2020-08-05  3:39 ` Ajit Khaparde
@ 2020-08-05 10:49 ` Andrew Rybchenko
  2020-08-05 13:31   ` Dekel Peled
  2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
  2 siblings, 1 reply; 12+ messages in thread
From: Andrew Rybchenko @ 2020-08-05 10:49 UTC (permalink / raw)
  To: Dekel Peled, dev
  Cc: jerinjacobk, stephen, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, asafp

On 8/4/20 7:01 PM, Dekel Peled wrote:
> Struct rte_flow_item_eth will be modified to include additional
> values, indicating existence or absence of VLAN headers following
> the ETH header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177349.html.
> Because of ABI break this change is proposed for 20.11.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 5201142..6241709 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -115,6 +115,11 @@ Deprecation Notices
>    following the IPv6 header, as proposed in RFC
>    https://mails.dpdk.org/archives/dev/2020-August/177257.html.
>  
> +* ethdev: The ``struct rte_flow_item_eth`` struct will be modified to include
> +  additional values, indicating existence or absence of VLAN headers
> +  following the ETH header, as proposed in RFC
> +  https://mails.dpdk.org/archives/dev/2020-August/177349.html.

It is unclear how it will coexist with VLAN items in a pattern.
Are you going to add consistency checks on ethdev-layer?

Also it is unclear why both bit fields and a number are
required.

Referenced RFC lacks definition of S-VLAN anc C-VLAN in
the context. Exact definition to avoid ambiguity.

So, it looks required to modify the structure, but I'd
not stick to referenced RFC, since the result could
differ a lot. May be reference it as just an example.


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
  2020-08-05 10:49 ` Andrew Rybchenko
@ 2020-08-05 13:31   ` Dekel Peled
  2020-08-05 13:44     ` Andrew Rybchenko
  0 siblings, 1 reply; 12+ messages in thread
From: Dekel Peled @ 2020-08-05 13:31 UTC (permalink / raw)
  To: Andrew Rybchenko, dev
  Cc: jerinjacobk, stephen, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, Asaf Penso

Thanks, PSB.

> -----Original Message-----
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> Sent: Wednesday, August 5, 2020 1:49 PM
> To: Dekel Peled <dekelp@mellanox.com>; dev@dpdk.org
> Cc: jerinjacobk@gmail.com; stephen@networkplumber.org;
> ajit.khaparde@broadcom.com; maxime.coquelin@redhat.com;
> olivier.matz@6wind.com; david.marchand@redhat.com;
> ferruh.yigit@intel.com; Asaf Penso <asafp@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
> 
> On 8/4/20 7:01 PM, Dekel Peled wrote:
> > Struct rte_flow_item_eth will be modified to include additional
> > values, indicating existence or absence of VLAN headers following the
> > ETH header, as proposed in RFC
> >
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
> dpdk.org%2Farchives%2Fdev%2F2020-
> August%2F177349.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
> 1b%7C0%7C0%7C637322213783925660&amp;sdata=4rEXCifnCHd2%2FA6AU4
> F3vjBcD7CfoTpT0traJ2z1fBk%3D&amp;reserved=0.
> > Because of ABI break this change is proposed for 20.11.
> >
> > Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 5201142..6241709 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -115,6 +115,11 @@ Deprecation Notices
> >    following the IPv6 header, as proposed in RFC
> >
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
> dpdk.org%2Farchives%2Fdev%2F2020-
> August%2F177257.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
> 1b%7C0%7C0%7C637322213783925660&amp;sdata=Ix4Y2vEXMoBek%2BkXw
> QazY11a9mkc3aiZRJDX9cbUiZk%3D&amp;reserved=0.
> >
> > +* ethdev: The ``struct rte_flow_item_eth`` struct will be modified to
> > +include
> > +  additional values, indicating existence or absence of VLAN headers
> > +  following the ETH header, as proposed in RFC
> > +
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
> dpdk.org%2Farchives%2Fdev%2F2020-
> August%2F177349.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
> 1b%7C0%7C0%7C637322213783925660&amp;sdata=4rEXCifnCHd2%2FA6AU4
> F3vjBcD7CfoTpT0traJ2z1fBk%3D&amp;reserved=0.
> 
> It is unclear how it will coexist with VLAN items in a pattern.
Same as the existing proto field coexist with following VLAN items.

> Are you going to add consistency checks on ethdev-layer?
Not planned currently.

> 
> Also it is unclear why both bit fields and a number are required.
I agree it is redundancy, added for flexibility, but can leave num_of_vlans only.

> 
> Referenced RFC lacks definition of S-VLAN anc C-VLAN in the context. Exact
> definition to avoid ambiguity.
These are well defined terms, I will add reference to spec.

> 
> So, it looks required to modify the structure, but I'd not stick to referenced
> RFC, since the result could differ a lot. May be reference it as just an
> example.
Thank you.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
  2020-08-05 13:31   ` Dekel Peled
@ 2020-08-05 13:44     ` Andrew Rybchenko
  2020-08-05 14:25       ` Dekel Peled
  0 siblings, 1 reply; 12+ messages in thread
From: Andrew Rybchenko @ 2020-08-05 13:44 UTC (permalink / raw)
  To: Dekel Peled, dev
  Cc: jerinjacobk, stephen, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, Asaf Penso

On 8/5/20 4:31 PM, Dekel Peled wrote:
> Thanks, PSB.
> 
>> -----Original Message-----
>> From: Andrew Rybchenko <arybchenko@solarflare.com>
>> Sent: Wednesday, August 5, 2020 1:49 PM
>> To: Dekel Peled <dekelp@mellanox.com>; dev@dpdk.org
>> Cc: jerinjacobk@gmail.com; stephen@networkplumber.org;
>> ajit.khaparde@broadcom.com; maxime.coquelin@redhat.com;
>> olivier.matz@6wind.com; david.marchand@redhat.com;
>> ferruh.yigit@intel.com; Asaf Penso <asafp@mellanox.com>
>> Subject: Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
>>
>> On 8/4/20 7:01 PM, Dekel Peled wrote:
>>> Struct rte_flow_item_eth will be modified to include additional
>>> values, indicating existence or absence of VLAN headers following the
>>> ETH header, as proposed in RFC
>>>
>> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
>> dpdk.org%2Farchives%2Fdev%2F2020-
>> August%2F177349.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
>> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
>> 1b%7C0%7C0%7C637322213783925660&amp;sdata=4rEXCifnCHd2%2FA6AU4
>> F3vjBcD7CfoTpT0traJ2z1fBk%3D&amp;reserved=0.
>>> Because of ABI break this change is proposed for 20.11.
>>>
>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>>> ---
>>>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>>> b/doc/guides/rel_notes/deprecation.rst
>>> index 5201142..6241709 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -115,6 +115,11 @@ Deprecation Notices
>>>    following the IPv6 header, as proposed in RFC
>>>
>> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
>> dpdk.org%2Farchives%2Fdev%2F2020-
>> August%2F177257.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
>> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
>> 1b%7C0%7C0%7C637322213783925660&amp;sdata=Ix4Y2vEXMoBek%2BkXw
>> QazY11a9mkc3aiZRJDX9cbUiZk%3D&amp;reserved=0.
>>>
>>> +* ethdev: The ``struct rte_flow_item_eth`` struct will be modified to
>>> +include
>>> +  additional values, indicating existence or absence of VLAN headers
>>> +  following the ETH header, as proposed in RFC
>>> +
>> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
>> dpdk.org%2Farchives%2Fdev%2F2020-
>> August%2F177349.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
>> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
>> 1b%7C0%7C0%7C637322213783925660&amp;sdata=4rEXCifnCHd2%2FA6AU4
>> F3vjBcD7CfoTpT0traJ2z1fBk%3D&amp;reserved=0.
>>
>> It is unclear how it will coexist with VLAN items in a pattern.
> Same as the existing proto field coexist with following VLAN items.
> 
>> Are you going to add consistency checks on ethdev-layer?
> Not planned currently.

IMHO, it is a must requirement if you introduce interface which
has inter-dependencies and requires generic consistency check.
It must be a part of ethdev, not every PMD.

> 
>>
>> Also it is unclear why both bit fields and a number are required.
> I agree it is redundancy, added for flexibility, but can leave num_of_vlans only.
> 
>>
>> Referenced RFC lacks definition of S-VLAN anc C-VLAN in the context. Exact
>> definition to avoid ambiguity.
> These are well defined terms, I will add reference to spec.

Basically, I agree that changes in the ETH item may be
required and OK to acknowledge the deprecation notice
without deep technical details. The only requirement is
API backward compatibility (i.e. just recompiled code
to take ABI changes into account must work).

> 
>>
>> So, it looks required to modify the structure, but I'd not stick to referenced
>> RFC, since the result could differ a lot. May be reference it as just an
>> example.
> Thank you.
> 
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
  2020-08-05 13:44     ` Andrew Rybchenko
@ 2020-08-05 14:25       ` Dekel Peled
  0 siblings, 0 replies; 12+ messages in thread
From: Dekel Peled @ 2020-08-05 14:25 UTC (permalink / raw)
  To: Andrew Rybchenko, dev
  Cc: jerinjacobk, stephen, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, Asaf Penso



> -----Original Message-----
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> Sent: Wednesday, August 5, 2020 4:44 PM
> To: Dekel Peled <dekelp@mellanox.com>; dev@dpdk.org
> Cc: jerinjacobk@gmail.com; stephen@networkplumber.org;
> ajit.khaparde@broadcom.com; maxime.coquelin@redhat.com;
> olivier.matz@6wind.com; david.marchand@redhat.com;
> ferruh.yigit@intel.com; Asaf Penso <asafp@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: announce change in ETH item struct
> 
> On 8/5/20 4:31 PM, Dekel Peled wrote:
> > Thanks, PSB.
> >
> >> -----Original Message-----
> >> From: Andrew Rybchenko <arybchenko@solarflare.com>
> >> Sent: Wednesday, August 5, 2020 1:49 PM
> >> To: Dekel Peled <dekelp@mellanox.com>; dev@dpdk.org
> >> Cc: jerinjacobk@gmail.com; stephen@networkplumber.org;
> >> ajit.khaparde@broadcom.com; maxime.coquelin@redhat.com;
> >> olivier.matz@6wind.com; david.marchand@redhat.com;
> >> ferruh.yigit@intel.com; Asaf Penso <asafp@mellanox.com>
> >> Subject: Re: [dpdk-dev] [PATCH] doc: announce change in ETH item
> >> struct
> >>
> >> On 8/4/20 7:01 PM, Dekel Peled wrote:
> >>> Struct rte_flow_item_eth will be modified to include additional
> >>> values, indicating existence or absence of VLAN headers following
> >>> the ETH header, as proposed in RFC
> >>>
> >>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
> >> dpdk.org%2Farchives%2Fdev%2F2020-
> >>
> August%2F177349.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
> >>
> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
> >>
> 1b%7C0%7C0%7C637322213783925660&amp;sdata=4rEXCifnCHd2%2FA6AU4
> >> F3vjBcD7CfoTpT0traJ2z1fBk%3D&amp;reserved=0.
> >>> Because of ABI break this change is proposed for 20.11.
> >>>
> >>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> >>> ---
> >>>  doc/guides/rel_notes/deprecation.rst | 5 +++++
> >>>  1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/doc/guides/rel_notes/deprecation.rst
> >>> b/doc/guides/rel_notes/deprecation.rst
> >>> index 5201142..6241709 100644
> >>> --- a/doc/guides/rel_notes/deprecation.rst
> >>> +++ b/doc/guides/rel_notes/deprecation.rst
> >>> @@ -115,6 +115,11 @@ Deprecation Notices
> >>>    following the IPv6 header, as proposed in RFC
> >>>
> >>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
> >> dpdk.org%2Farchives%2Fdev%2F2020-
> >>
> August%2F177257.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
> >>
> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
> >>
> 1b%7C0%7C0%7C637322213783925660&amp;sdata=Ix4Y2vEXMoBek%2BkXw
> >> QazY11a9mkc3aiZRJDX9cbUiZk%3D&amp;reserved=0.
> >>>
> >>> +* ethdev: The ``struct rte_flow_item_eth`` struct will be modified
> >>> +to include
> >>> +  additional values, indicating existence or absence of VLAN
> >>> +headers
> >>> +  following the ETH header, as proposed in RFC
> >>> +
> >>
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.
> >> dpdk.org%2Farchives%2Fdev%2F2020-
> >>
> August%2F177349.html&amp;data=02%7C01%7Cdekelp%40mellanox.com%7
> >>
> C7d12c0524d434c10f35a08d8392d3f53%7Ca652971c7d2e4d9ba6a4d149256f46
> >>
> 1b%7C0%7C0%7C637322213783925660&amp;sdata=4rEXCifnCHd2%2FA6AU4
> >> F3vjBcD7CfoTpT0traJ2z1fBk%3D&amp;reserved=0.
> >>
> >> It is unclear how it will coexist with VLAN items in a pattern.
> > Same as the existing proto field coexist with following VLAN items.
> >
> >> Are you going to add consistency checks on ethdev-layer?
> > Not planned currently.
> 
> IMHO, it is a must requirement if you introduce interface which has inter-
> dependencies and requires generic consistency check.
> It must be a part of ethdev, not every PMD.
OK, will take it into account in the implementation.

> 
> >
> >>
> >> Also it is unclear why both bit fields and a number are required.
> > I agree it is redundancy, added for flexibility, but can leave num_of_vlans
> only.
> >
> >>
> >> Referenced RFC lacks definition of S-VLAN anc C-VLAN in the context.
> >> Exact definition to avoid ambiguity.
> > These are well defined terms, I will add reference to spec.
> 
> Basically, I agree that changes in the ETH item may be required and OK to
> acknowledge the deprecation notice without deep technical details. The only
> requirement is API backward compatibility (i.e. just recompiled code to take
> ABI changes into account must work).
Of course, code including proposed change is built and runs.

> 
> >
> >>
> >> So, it looks required to modify the structure, but I'd not stick to
> >> referenced RFC, since the result could differ a lot. May be reference
> >> it as just an example.
> > Thank you.
> >
> >


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
  2020-08-04 16:01 [dpdk-dev] [PATCH] doc: announce change in ETH item struct Dekel Peled
  2020-08-05  3:39 ` Ajit Khaparde
  2020-08-05 10:49 ` Andrew Rybchenko
@ 2020-08-06 10:45 ` Dekel Peled
  2020-08-06 12:25   ` Thomas Monjalon
  2020-08-06 17:07   ` Ori Kam
  2 siblings, 2 replies; 12+ messages in thread
From: Dekel Peled @ 2020-08-06 10:45 UTC (permalink / raw)
  To: dev
  Cc: jerinjacobk, stephen, arybchenko, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, asafp

Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
to include an additional value, indicating existence or absence of VLAN
headers following the current header, as proposed in RFC
https://mails.dpdk.org/archives/dev/2020-August/177536.html.
Because of ABI break this change is proposed for 20.11.

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 5201142..2899f56 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -115,6 +115,11 @@ Deprecation Notices
   following the IPv6 header, as proposed in RFC
   https://mails.dpdk.org/archives/dev/2020-August/177257.html.
 
+* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
+  structs will be modified, to include an additional value, indicating existence
+  or absence of a VLAN header following the current header, as proposed in RFC
+  https://mails.dpdk.org/archives/dev/2020-August/177536.html.
+
 * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly made
   ABI stable in the v19.11 release. The TM maintainer and other contributors have
   agreed to keep the TM APIs as experimental in expectation of additional spec
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
  2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
@ 2020-08-06 12:25   ` Thomas Monjalon
  2020-08-06 15:14     ` Andrew Rybchenko
  2020-08-06 17:07   ` Ori Kam
  1 sibling, 1 reply; 12+ messages in thread
From: Thomas Monjalon @ 2020-08-06 12:25 UTC (permalink / raw)
  To: Dekel Peled
  Cc: dev, jerinjacobk, stephen, arybchenko, ajit.khaparde,
	maxime.coquelin, olivier.matz, david.marchand, ferruh.yigit,
	asafp

06/08/2020 12:45, Dekel Peled:
> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> to include an additional value, indicating existence or absence of VLAN
> headers following the current header, as proposed in RFC
> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> Because of ABI break this change is proposed for 20.11.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
> +  structs will be modified, to include an additional value, indicating existence
> +  or absence of a VLAN header following the current header, as proposed in RFC
> +  https://mails.dpdk.org/archives/dev/2020-August/177536.html.

Specifying match patterns on none or multiple extensions
is difficult to manage with rte_flow.
It seems this approach of adding explicit fields in the items
can work well.

Acked-by: Thomas Monjalon <thomas@monjalon.net>



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
  2020-08-06 12:25   ` Thomas Monjalon
@ 2020-08-06 15:14     ` Andrew Rybchenko
  2020-08-06 15:50       ` Ajit Khaparde
  0 siblings, 1 reply; 12+ messages in thread
From: Andrew Rybchenko @ 2020-08-06 15:14 UTC (permalink / raw)
  To: Thomas Monjalon, Dekel Peled
  Cc: dev, jerinjacobk, stephen, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, asafp

On 8/6/20 3:25 PM, Thomas Monjalon wrote:
> 06/08/2020 12:45, Dekel Peled:
>> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
>> to include an additional value, indicating existence or absence of VLAN
>> headers following the current header, as proposed in RFC
>> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
>> Because of ABI break this change is proposed for 20.11.
>>
>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>> ---
>> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
>> +  structs will be modified, to include an additional value, indicating existence
>> +  or absence of a VLAN header following the current header, as proposed in RFC
>> +  https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> Specifying match patterns on none or multiple extensions
> is difficult to manage with rte_flow.
> It seems this approach of adding explicit fields in the items
> can work well.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Similar to IPv6, it looks required to add extra information to ETH (and may
be VLAN) item, but I'm not sure that proposed solution is 100% OK.
Anyway, the scope of the deprecation notice is ongoing changes, so:

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
  2020-08-06 15:14     ` Andrew Rybchenko
@ 2020-08-06 15:50       ` Ajit Khaparde
  2020-08-06 21:57         ` Thomas Monjalon
  0 siblings, 1 reply; 12+ messages in thread
From: Ajit Khaparde @ 2020-08-06 15:50 UTC (permalink / raw)
  To: Andrew Rybchenko
  Cc: Thomas Monjalon, Dekel Peled, dpdk-dev, Jerin Jacob,
	Stephen Hemminger, maxime.coquelin, Olivier Matz, David Marchand,
	Ferruh Yigit, Asaf Penso

On Thu, Aug 6, 2020 at 8:14 AM Andrew Rybchenko <arybchenko@solarflare.com>
wrote:

> On 8/6/20 3:25 PM, Thomas Monjalon wrote:
> > 06/08/2020 12:45, Dekel Peled:
> >> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> >> to include an additional value, indicating existence or absence of VLAN
> >> headers following the current header, as proposed in RFC
> >> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> >> Because of ABI break this change is proposed for 20.11.
> >>
> >> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> >> ---
> >> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct
> rte_flow_item_vlan``
> >> +  structs will be modified, to include an additional value, indicating
> existence
> >> +  or absence of a VLAN header following the current header, as
> proposed in RFC
> >> +  https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > Specifying match patterns on none or multiple extensions
> > is difficult to manage with rte_flow.
> > It seems this approach of adding explicit fields in the items
> > can work well.
> >
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> Similar to IPv6, it looks required to add extra information to ETH (and may
> be VLAN) item, but I'm not sure that proposed solution is 100% OK.
> Anyway, the scope of the deprecation notice is ongoing changes, so:
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
  2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
  2020-08-06 12:25   ` Thomas Monjalon
@ 2020-08-06 17:07   ` Ori Kam
  1 sibling, 0 replies; 12+ messages in thread
From: Ori Kam @ 2020-08-06 17:07 UTC (permalink / raw)
  To: Dekel Peled, dev
  Cc: jerinjacobk, stephen, arybchenko, ajit.khaparde, maxime.coquelin,
	olivier.matz, david.marchand, ferruh.yigit, Asaf Penso



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> 
> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> to include an additional value, indicating existence or absence of VLAN
> headers following the current header, as proposed in RFC
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> August%2F177536.html&amp;data=02%7C01%7Corika%40mellanox.com%7Cb5
> 9964d529f14539086008d839f621db%7Ca652971c7d2e4d9ba6a4d149256f461b
> %7C0%7C0%7C637323076576373546&amp;sdata=mWvf%2FeYiYhIXcoFaZMikx
> TqcJIS%2FxLQuNHGUqzcAf6w%3D&amp;reserved=0.
> Because of ABI break this change is proposed for 20.11.
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 5201142..2899f56 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -115,6 +115,11 @@ Deprecation Notices
>    following the IPv6 header, as proposed in RFC
> 
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> August%2F177257.html&amp;data=02%7C01%7Corika%40mellanox.com%7Cb5
> 9964d529f14539086008d839f621db%7Ca652971c7d2e4d9ba6a4d149256f461b
> %7C0%7C0%7C637323076576373546&amp;sdata=CR3%2B3iKBdLnGo4oRYy1ev
> MMsKxwVy%2Fzf6R44dQt2An8%3D&amp;reserved=0.
> 
> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct rte_flow_item_vlan``
> +  structs will be modified, to include an additional value, indicating existence
> +  or absence of a VLAN header following the current header, as proposed in
> RFC
> +
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpd
> k.org%2Farchives%2Fdev%2F2020-
> August%2F177536.html&amp;data=02%7C01%7Corika%40mellanox.com%7Cb5
> 9964d529f14539086008d839f621db%7Ca652971c7d2e4d9ba6a4d149256f461b
> %7C0%7C0%7C637323076576373546&amp;sdata=mWvf%2FeYiYhIXcoFaZMikx
> TqcJIS%2FxLQuNHGUqzcAf6w%3D&amp;reserved=0.
> +
>  * traffic manager: All traffic manager API's in ``rte_tm.h`` were mistakenly
> made
>    ABI stable in the v19.11 release. The TM maintainer and other contributors
> have
>    agreed to keep the TM APIs as experimental in expectation of additional spec
> --
> 1.8.3.1

Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs
  2020-08-06 15:50       ` Ajit Khaparde
@ 2020-08-06 21:57         ` Thomas Monjalon
  0 siblings, 0 replies; 12+ messages in thread
From: Thomas Monjalon @ 2020-08-06 21:57 UTC (permalink / raw)
  To: Dekel Peled
  Cc: Andrew Rybchenko, dev, dpdk-dev, Jerin Jacob, Stephen Hemminger,
	maxime.coquelin, Olivier Matz, David Marchand, Ferruh Yigit,
	Asaf Penso, Ajit Khaparde

> > >> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified,
> > >> to include an additional value, indicating existence or absence of VLAN
> > >> headers following the current header, as proposed in RFC
> > >> https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > >> Because of ABI break this change is proposed for 20.11.
> > >>
> > >> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> > >> ---
> > >> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct
> > rte_flow_item_vlan``
> > >> +  structs will be modified, to include an additional value, indicating
> > existence
> > >> +  or absence of a VLAN header following the current header, as
> > proposed in RFC
> > >> +  https://mails.dpdk.org/archives/dev/2020-August/177536.html.
> > > Specifying match patterns on none or multiple extensions
> > > is difficult to manage with rte_flow.
> > > It seems this approach of adding explicit fields in the items
> > > can work well.
> > >
> > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > Similar to IPv6, it looks required to add extra information to ETH (and may
> > be VLAN) item, but I'm not sure that proposed solution is 100% OK.
> > Anyway, the scope of the deprecation notice is ongoing changes, so:
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Ori Kam <orika@mellanox.com>

Applied



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2020-08-06 21:58 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 16:01 [dpdk-dev] [PATCH] doc: announce change in ETH item struct Dekel Peled
2020-08-05  3:39 ` Ajit Khaparde
2020-08-05 10:49 ` Andrew Rybchenko
2020-08-05 13:31   ` Dekel Peled
2020-08-05 13:44     ` Andrew Rybchenko
2020-08-05 14:25       ` Dekel Peled
2020-08-06 10:45 ` [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs Dekel Peled
2020-08-06 12:25   ` Thomas Monjalon
2020-08-06 15:14     ` Andrew Rybchenko
2020-08-06 15:50       ` Ajit Khaparde
2020-08-06 21:57         ` Thomas Monjalon
2020-08-06 17:07   ` Ori Kam

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git