From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AA58023D for ; Thu, 26 Jul 2018 20:29:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 33FA221DCC; Thu, 26 Jul 2018 14:29:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 26 Jul 2018 14:29:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=0KctKCNjk6CzYR5rVXcnc6/qP8 3LFS1zl2jc0LfT1fQ=; b=pUwAYmm6XyJu0nRhMjrZ6wkxgCmUq/V52EfcQLWm7V y1Fr52yHVYEXioKR3uji0NhRvXknIiKUyDJCRIupQgF8BCwMxSgwRdDgQZ85dw0l /5D4NKAMf+UtGrHFjRbcl6mrwEXF6+q+l+zM6y0UuQqg6v6LIyvD4Zn0YjZYgkoE g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=0KctKC Njk6CzYR5rVXcnc6/qP83LFS1zl2jc0LfT1fQ=; b=avb9GgJ/BW3aFKueCB25ac G/zAlho5r7j/DUSL/XT1s9oOgaf9mwClkYzqoDqrqIyag4VKoL2leZURczEOqKxy MttkpUgIFhLNQ8n3e0X63vjb38WOsRcxui2sypoOVOggPIT9SdR7tTRY4QPYyN0m vXf4rNy2k4KvOCI8f8VJGhBkkeMJpS2xhm7fItEd1KW3YGK+5swGJBoy9lFAz5Ob pJu7ZWFwt3d2zy9e1xMFi1qBpSnoV5zzVaFNwx8sBmCNutG9edcfHjgE3YbCMdO4 KE/LIcksLUp2QnREQClHZ9tIFePT90wsB6JKZVyrjIm96ghtewIYebiBRqAS/LnA == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A50011027B; Thu, 26 Jul 2018 14:29:34 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org, Reshma Pattan Date: Thu, 26 Jul 2018 20:29:30 +0200 Message-ID: <4143071.v8a4Ec99S8@xps> In-Reply-To: <20180702145547.8376-1-remy.horton@intel.com> References: <20180702145547.8376-1-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] lib/metrics: fix silent fail when uninitialised X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 18:29:36 -0000 02/07/2018 16:55, Remy Horton: > If rte_metrics_init() had not been called and hence the internal > metric storage is not allocated, rte_metrics_get_values() and > rte_metrics_get_name() would silently fail by returning zero > (i.e. no metrics registered). This patch changes the result of > this scenario to an explicit fail by returning -EIO. > > Fixes: 349950ddb9c5 ("metrics: add information metrics library") > > Signed-off-by: Remy Horton Applied, thanks