From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id B9D2B37AF for ; Thu, 28 Feb 2019 12:22:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 566B522565; Thu, 28 Feb 2019 06:22:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Feb 2019 06:22:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=XEpGePswbDq4KAZ70td4kyESwsalUY1/DpBxD9ip6bk=; b=dOZ2lD8+4Yq+ mhKrGa1il9egHTehjxxqwfvndpUlOvGTt8EmHSmojWOJL5u+Cfy+36rLXgNEqe4C 460pu+MmB0IvDOeeBd8KdNvMneSTfx2UQ6qhfGY5YEb5sCaRexe2NRtlPsJBDciQ qyY3Zg8qvoPme7DCl0MeXWPcP5Cb/Fw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=XEpGePswbDq4KAZ70td4kyESwsalUY1/DpBxD9ip6 bk=; b=rG9w8n8LpacABb6Ka+efd9C+M4Un1gKLBADK9vH2OHDE1z0fEtIyZF2aK LZubPGzQhrduzpFQj/g5h8OIr1Rjl0ILSZ633p9arH4y15IAexDIq+ZEl8rilBNj vdLth58IrRk3ng5E3tfOWTypV65jNhnPrZR2izXvfxiE2dLp9ICzoigeNzClm5q/ CUASPWuGyEMpvugss1EtVsw2/RHUm7frpyDq1gheKPPVipVoJyRYtVGVQhn18V1F 7s8oiASOVhuiI+LlSmwzszLtlk5eq1CFMmEx4B5DDdwl1XtNtG6FSFqsUQOyLa/m BNY7Lr8i8GWjpGLcJm01Y+3HNyEbQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdefgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epleefrdeirddugeelrdduudegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgr shesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 14FC110328; Thu, 28 Feb 2019 06:22:02 -0500 (EST) From: Thomas Monjalon To: Michael Santana Cc: dev@dpdk.org, Van Haaren Harry , ramirose@gmail.com, Bruce Richardson Date: Thu, 28 Feb 2019 12:21:58 +0100 Message-ID: <4146661.2v2ioqZAr6@xps> In-Reply-To: <20190214193547.30783-2-msantana@redhat.com> References: <20190213190813.12702-1-msantana@redhat.com> <20190214193547.30783-1-msantana@redhat.com> <20190214193547.30783-2-msantana@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] Enable codespell by default. Can be disabled from config file. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 11:22:08 -0000 14/02/2019 20:35, Michael Santana: > Enable codespell by default. > codespell is a feature by checkpatch.pl that > checks for common spelling mistakes in patches. What is the difference between codespell and spelling.txt included with checkpatch? Is it just a different dictionary? > This feature is disabled by default. To enable it one must add > the '--codespell' flag to the $options variable in > checkpatches.sh. We need also to specify the dictionary path if not in /usr/share/codespell/dictionary.txt In my case, it is in /usr/lib/python3.7/site-packages/codespell_lib/data/dictionary.txt > With this change codespell is enabled by default. It seems it is not enabled by default, because we need DPDK_CHECKPATCH_CODESPELL=enable > The user can decide to turn off codespell from a one of the config > files read by checkpatches.sh. [...] > # override default Linux options > options="--no-tree" > +if [ "$DPDK_CHECKPATCH_CODESPELL" == "enable" ]; then What about allowing either "enable" or a path? If it is a path (have some slash), then we can add --codespellfile option. > + options="$options --codespell" > +fi > options="$options --max-line-length=$length" > options="$options --show-types" > options="$options --ignore=LINUX_VERSION_CODE,\ >