From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D3D6B23D for ; Mon, 18 Dec 2017 17:30:28 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 30B9120DAA; Mon, 18 Dec 2017 11:30:28 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 18 Dec 2017 11:30:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5xNC7KCfJ9N3+Ydvhdd5NeaUiB WezW8Et1Zl9k0QJww=; b=oqxeEdZzlbcM4ZkWKvYzUAvOXnuQYTQUHlgw9UnSyE cwG6/Nh0a/j73mKJtEjTi53sH2PIncvsbF6o5PDkFeNmV1cIM6hMREuL9E/XouZk 7fnZdVjyQn7fMN3k7lSIKLoJWKfJael3eO/dpS9iB1nScf3HeCvKjc81PLA/Wrmt I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5xNC7K CfJ9N3+Ydvhdd5NeaUiBWezW8Et1Zl9k0QJww=; b=qKnLAHAMJ7V4WhjfptdoOs m8QIOKUR5ElKoTJ0GgfBvOq9vYdI4sIc9oO/ZMjG/3Z8/NsvWtjfAP39VuCdM2EP VZQsKjwlJ4UY1n/hHBXWkBuzdbCEcDio7sCS1qA3TEY89EZpFDVHRdTlDbK0H3H7 NvcqFOX8tK2xOfGSOak32SVrNw3/pb3T7e+vhdWySw3vXK+i3+TmYtF1nFUxrCaC A2k55qRy9IhahtiWRzxmn3ViMMSOlTJfL4Eh+2vgZIMpDG6ABH175qE9DiDhpSis i9+yFD5SbP5WNnUDQZXl7id/X4T4mvOQQ3Ozey3eIj9K6q8BxE4VJxDeq/+zMx/A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D7277E4C8; Mon, 18 Dec 2017 11:30:27 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Hemant Agrawal , dev@dpdk.org, stephen@networkplumber.org Date: Mon, 18 Dec 2017 17:30:26 +0100 Message-ID: <4147827.fBL4TnQB7r@xps> In-Reply-To: <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com> References: <1512718913-11462-1-git-send-email-hemant.agrawal@nxp.com> <1513600744-13749-2-git-send-email-hemant.agrawal@nxp.com> <20171218155217.GA10816@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/4] change root makefile license to SPDX tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 16:30:29 -0000 18/12/2017 16:52, Bruce Richardson: > On Mon, Dec 18, 2017 at 06:09:02PM +0530, Hemant Agrawal wrote: > > --- a/GNUmakefile > > +++ b/GNUmakefile > > @@ -1,33 +1,6 @@ > > -# BSD LICENSE > > +# SPDX-License-Identifier: BSD-3-Clause > > # > > # Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > > Actually, minor comment, can we remove the blank line between the SPDX > identifier and the copyright? Given that in the majority of cases, we > will only have one line each, having a space between them is a) probably > unnecessary, and b) looks weird IMHO. > > I'm currently working on a patchset to update the meson.build files, and > I think having: > > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > looks better as a header than two one-line paragraphs. +1, I agree with Bruce