[PATCH] test: eal: update base-virtaddr parameter test

[PATCH] test: eal: update base-virtaddr parameter test

[Aaron Conole]

When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced
a number of static variables.  These ended up filling the lower address space
enough that on some platforms, the min addr for heap address to start was
not within the range specified by base-virtaddr.  This is dependent on both
build and link time options.

The simplest resolution is to just update the base virtaddr parameter to
move the rte config location.

Reported-by: Patrick Robb <probb@iol.unh.edu>
Suggested-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 app/test/test_eal_flags.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index d2b91e2075..148e9098e8 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -1017,7 +1017,7 @@ test_misc_flags(void)
 
 	/* try running with base-virtaddr param */
 	const char *argv13[] = {prgname, "--file-prefix=virtaddr",
-			"--base-virtaddr=0x12345678"};
+			"--base-virtaddr=0x23456789"};
 
 	/* try running with --vfio-intr INTx flag */
 	const char *argv14[] = {prgname, "--file-prefix=intr",
-- 
2.40.1

Re: [PATCH] test: eal: update base-virtaddr parameter test

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

On Thu, Jul 20, 2023 at 6:09 AM Aaron Conole <aconole@redhat.com> wrote:
>
> When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced
> a number of static variables.  These ended up filling the lower address space
> enough that on some platforms, the min addr for heap address to start was
> not within the range specified by base-virtaddr.  This is dependent on both
> build and link time options.
>
> The simplest resolution is to just update the base virtaddr parameter to
> move the rte config location.
>
> Reported-by: Patrick Robb <probb@iol.unh.edu>
> Suggested-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
ACK.
I tested again and the test passed with this change. Thanks.

> ---
>  app/test/test_eal_flags.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index d2b91e2075..148e9098e8 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -1017,7 +1017,7 @@ test_misc_flags(void)
>
>         /* try running with base-virtaddr param */
>         const char *argv13[] = {prgname, "--file-prefix=virtaddr",
> -                       "--base-virtaddr=0x12345678"};
> +                       "--base-virtaddr=0x23456789"};
>
>         /* try running with --vfio-intr INTx flag */
>         const char *argv14[] = {prgname, "--file-prefix=intr",
> --
> 2.40.1
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

Re: [PATCH] test: eal: update base-virtaddr parameter test

[Thomas Monjalon]

20/07/2023 16:07, Ajit Khaparde:
> On Thu, Jul 20, 2023 at 6:09 AM Aaron Conole <aconole@redhat.com> wrote:
> >
> > When 97435d7906 ("net/bnxt: update Truflow core") was applied, it introduced
> > a number of static variables.  These ended up filling the lower address space
> > enough that on some platforms, the min addr for heap address to start was
> > not within the range specified by base-virtaddr.  This is dependent on both
> > build and link time options.
> >
> > The simplest resolution is to just update the base virtaddr parameter to
> > move the rte config location.
> >
> > Reported-by: Patrick Robb <probb@iol.unh.edu>
> > Suggested-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Signed-off-by: Aaron Conole <aconole@redhat.com>
> ACK.
> I tested again and the test passed with this change. Thanks.

Applied, thanks.