DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pavel Boldin <pboldin@mirantis.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in `eventfd_link'
Date: Fri, 27 Mar 2015 14:15:25 +0100	[thread overview]
Message-ID: <4151601.EsHxSRlnWS@xps13> (raw)
In-Reply-To: <CACf4_B9ims0bL3fqk5Pm6sTHkm7pdHcTgFNXLvKYZf5Gip9LDg@mail.gmail.com>

> > > > Due to increased `struct file's reference counter subsequent call
> > > > to `filp_close' does not free the `struct file'. Prepend `fput' call
> > > > to decrease the reference counter.
> > > >
> > > > Signed-off-by: Pavel Boldin <pboldin@mirantis.com>
> > >
> > > Acked-by Huawei Xie <huawei.xie@intel.com>
> >
> > Applied, thanks
> 
> What should I do with the refactoring patch in your opinion?
> 
> Should I split it in parts to ease review?

I didn't review it so I have no good advice.
But in general, it's better to split patches in logic units if it makes sense.
Note that we are closing 2.0. Refactoring patches are deffered to 2.1.

  reply	other threads:[~2015-03-27 13:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 12:53 Pavel Boldin
2015-03-23 14:21 ` Xie, Huawei
2015-03-23 14:36   ` Pavel Boldin
2015-03-23 14:41     ` Xie, Huawei
2015-03-23 14:51       ` Pavel Boldin
2015-03-23 15:16         ` Xie, Huawei
2015-03-23 15:22           ` Thomas Monjalon
2015-03-23 15:27           ` Pavel Boldin
2015-03-23 15:36             ` Xie, Huawei
2015-03-23 15:44               ` Pavel Boldin
2015-03-24  6:28 ` Xie, Huawei
2015-03-24 11:10   ` Pavel Boldin
2015-03-24 16:20     ` Xie, Huawei
2015-03-24 20:08       ` Pavel Boldin
2015-03-26  7:53         ` Xie, Huawei
2015-03-27 11:12   ` Thomas Monjalon
2015-03-26  7:56 ` Xie, Huawei
2015-03-26 15:17   ` Pavel Boldin
2015-03-27 11:10   ` Thomas Monjalon
2015-03-27 12:36     ` Pavel Boldin
2015-03-27 13:15       ` Thomas Monjalon [this message]
2015-03-26 15:20 ` Xie, Huawei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4151601.EsHxSRlnWS@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=pboldin@mirantis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).