From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id E30C75A26
 for <dev@dpdk.org>; Fri, 27 Mar 2015 14:16:08 +0100 (CET)
Received: by wibbg6 with SMTP id bg6so26208724wib.0
 for <dev@dpdk.org>; Fri, 27 Mar 2015 06:16:08 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=aM6ng6jQTp1ADxTA3wxOAWVyvdfHRaI7c8f+XXbJAj4=;
 b=LCRwmOwNlAGRZYcR76apNY9gOlgoN0INTgrePrzHJAZNUvdEIT/pujV+CSM6Qbt3vX
 1pRTdVUkKjv2sdiWUv/VtHqa4LqLmaf93wkNyaV/JsSjsw0pV665hfoa3EAYp4gBJgpN
 3raiaJwBM5DO/AqiKuKquzPy+In0NR3wHjbkKubwtEIPYSR3GJKhm9UVOSWV0KyAACLU
 EZ7OePjNoUND4fyk4VzxKEqiEn7UXFQblkhUsPzOsnQzajvcBn1vE7AwiHyi5rUuU8Le
 ROnl8kv49gBv31cb+xZwI0Q5TmWGB6MQ8YoNs0SzAsRbd2ekO+ZqEGG5Xqwe7GNsv8K1
 ozPg==
X-Gm-Message-State: ALoCoQlqDg+5Htfpk80tsBAGCfJn8iaLi+IPeI6mk6dj8CsdvqGp/OEAuhoVNs76G3AHy/BXAGwl
X-Received: by 10.194.93.2 with SMTP id cq2mr38645484wjb.69.1427462168776;
 Fri, 27 Mar 2015 06:16:08 -0700 (PDT)
Received: from xps13.localnet (151.16.90.92.rev.sfr.net. [92.90.16.151])
 by mx.google.com with ESMTPSA id g2sm7222128wib.1.2015.03.27.06.16.06
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 27 Mar 2015 06:16:07 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pavel Boldin <pboldin@mirantis.com>
Date: Fri, 27 Mar 2015 14:15:25 +0100
Message-ID: <4151601.EsHxSRlnWS@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <CACf4_B9ims0bL3fqk5Pm6sTHkm7pdHcTgFNXLvKYZf5Gip9LDg@mail.gmail.com>
References: <1427115225-14489-1-git-send-email-pboldin@mirantis.com>
 <15186425.TaoBqciV4t@xps13>
 <CACf4_B9ims0bL3fqk5Pm6sTHkm7pdHcTgFNXLvKYZf5Gip9LDg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in
	`eventfd_link'
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Mar 2015 13:16:09 -0000

> > > > Due to increased `struct file's reference counter subsequent call
> > > > to `filp_close' does not free the `struct file'. Prepend `fput' call
> > > > to decrease the reference counter.
> > > >
> > > > Signed-off-by: Pavel Boldin <pboldin@mirantis.com>
> > >
> > > Acked-by Huawei Xie <huawei.xie@intel.com>
> >
> > Applied, thanks
> 
> What should I do with the refactoring patch in your opinion?
> 
> Should I split it in parts to ease review?

I didn't review it so I have no good advice.
But in general, it's better to split patches in logic units if it makes sense.
Note that we are closing 2.0. Refactoring patches are deffered to 2.1.