From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 6DCAA5A4D for ; Wed, 9 Dec 2015 21:10:43 +0100 (CET) Received: by wmuu63 with SMTP id u63so238058116wmu.0 for ; Wed, 09 Dec 2015 12:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Mx8c5x9+hw+uOomz9pBy1WAUIrOQJqf2LsCzAcr+bQM=; b=C8sBZdRNU2brPrADbnl/bBz4y6NFNnEpmjPh8Mh7yIEgdnnM/FWS5RbQjP2k3OkOM7 +8Bi+R1YRi7C3Pgwf9NjM7W4HsSdNvR+951yP2idzLqtH0G0AM7CELRoQnD08yEbGhZS 2a1qBKKFfgKseOqI9NmfwXJw8kNAbIVJEDeYfSevMejc+FUVcymyAdONa9zKGEKMxSLq 1JzOKtTXi+8txZVWAertZi+UfmCw2rKdA8uAxNtVZ4tU3QsSniz9Lnz3mFp+h+TEhLEW PmpQqCmKs9UFlkTuNZQELgVMDp30etP+SoBfU2n11RwbnWUhzY9G52U3gX5O3Zp+a7g7 A2FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Mx8c5x9+hw+uOomz9pBy1WAUIrOQJqf2LsCzAcr+bQM=; b=l95lpxIbpoTBBz+k/ichgz1OeHOCD/GpW4TWiyNO4xpv32ve3UEngeZmHqt59eWCzb yJssjEyUqYMQ4ZznwFXqrZA6gUaY24qRgNnEirT9sK7q1CKAx9SfzwcwM7vz2GC3Ji0C AAG02BQv30BPPnTV+jT1zmIdpMWXKqAwlgnvj7gWeDiU+FiSvqlWH6h4+dtO1KjRY2t/ L50bxwMz/fwEsYSo4GDmpboyrT8VDRINqe9Pl6e3SEunf1/aSQToJIDOVGJSJqFonRHu RWzQT+lkjwdV6hzrANxMKZqEqzIFzFEu6pEIOYV2zEXGsCKUrjWq4M85J6sG0oqOMZop rM+w== X-Gm-Message-State: ALoCoQlzossECUXS9K4INwdbmU+buona2idzpAjR941/x8wWWglPQiCERAsx3YA33phN5v8j8rK15NU+SWLFms5hMLHRaMWgHg== X-Received: by 10.194.78.212 with SMTP id d20mr8814574wjx.70.1449691843304; Wed, 09 Dec 2015 12:10:43 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id cs4sm9164940wjc.10.2015.12.09.12.10.42 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Dec 2015 12:10:42 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Date: Wed, 09 Dec 2015 21:09:27 +0100 Message-ID: <4152327.aAbH2kO9Wx@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1449543912-31066-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1449543912-31066-1-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong queue index for VIRTIO_PCI_QUEUE_SEL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 20:10:43 -0000 2015-12-08 11:05, Yuanhan Liu: > We should provide VIRTIO_PCI_QUEUE_SEL with vq->vq_queue_idx, > but not vq->queue_id. > > vq->queue_id is the queue id from rte_eth_rx/tx_queue_setup(), > which always starts from 0 no matter which queue it is. However, > for virtio, even number is for RX queue, and odd number is for > TX queue. > > Fixes: 5382b188fb8a ("virtio: add queue release") > > Cc: Bernard Iremonger Bernard was not CC'ed. > Signed-off-by: Yuanhan Liu Applied, thanks