From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4862037AF for ; Sun, 27 May 2018 22:51:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A530821BBB; Sun, 27 May 2018 16:51:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 27 May 2018 16:51:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5F2UuNiR6S8Rdoa9+LSPWS97xs BQHiWqH328E5aFGtE=; b=ImkzitEqI+OTMUNsRZ8SW67fuO2vzmBTryMG2Wkzsn +oF6RWOL95v/bUXw3ZMPXo6zWSbjm3jQnEmqYeeXfNNFA3eQNhXq6R27t65A+kFs S4Qzze7OpOer/zgby3KW4GHscdsmcufMjxBhfskIjOZer4RXLyHfPfkZC7VYLDQJ A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=5F2UuN iR6S8Rdoa9+LSPWS97xsBQHiWqH328E5aFGtE=; b=mg5idVT81VSkYhrXYRCFa6 VZ+g9eFCXe3nZmtInbiP6ZlkzBhUXlxeaedJbE1VkJoEcAaW3KTP5mRCB8tccvtQ 3Z1FIhwc2UP7qpWmQrRveuYMXDfuH5Oa+XT5wSvx8UUHzspB1VJ/wCWvZn5wBb8n iph4d6yPiXTU0EUwe/R3tSjzOrxutUD1wzlU9FV3yeQBoqY6ojuRZjX9/Cl0EYgB L/Eo7I1cOCDTJshuXIUuI4imvpeaon+sJd0b4aifbLLfEOBs9ky6N21vg6YTSsw6 7Lg0q0Sp2JahbNJPKbhhFfzLgK+Waxg/K2+0rg6QuB18FZhGXh0SnvfXe/jz3/FA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EDF37E4117; Sun, 27 May 2018 16:50:59 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: dev@dpdk.org, Ferruh Yigit Date: Sun, 27 May 2018 22:50:58 +0200 Message-ID: <4156041.IfarTdeXU8@xps> In-Reply-To: <9253aa4f-17d2-53f7-8b57-4a9b5d6e1f53@intel.com> References: <20180212161312.31795-1-pbhagavatula@caviumnetworks.com> <9253aa4f-17d2-53f7-8b57-4a9b5d6e1f53@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: add script to verify map files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2018 20:51:01 -0000 Sorry for having missed this patch during so long. 13/02/2018 11:48, Ferruh Yigit: > On 2/12/2018 4:13 PM, Pavan Nikhilesh wrote: > > This script checks for the symbols specified in the map files against > > the symbols present in the map file directory. > > Currently, the script checks for map files in drivers and lib directory. > > > > Example: > > ./devtools/check-map.py > > > > The following symbols are unused : > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/mempool/dpaa/... > > ['rte_dpaa_pool_table'] > > > > Map file : /home/pavan/Work/clean/dpdk/drivers/bus/fslmc/... > > ['qbman_get_version', 'qbman_swp_send_multiple'] > > > > ... > > > > Signed-off-by: Pavan Nikhilesh > > +1 to improve our tools. > > Acked-by: Ferruh Yigit I agree we must have more tools. I think this check can be a lot simpler as a shell script, instead of Python. It does not need the list features of Python. I've run it and I see it does not catch symbols which are renamed with a prefix. Example: vfio_get_group_fd became rte_vfio_get_group_fd