From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0CEFF1B294 for ; Wed, 25 Oct 2017 11:00:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7FD6C224E2; Wed, 25 Oct 2017 05:00:01 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 25 Oct 2017 05:00:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=PTdGkF2Fbg8VUVYEXuarUB0HC8 XM2FbmbfV2iV+75Z0=; b=IwNCUtwRdzQBOwUuue19ncTZfYXzQ8gYomKD8dUn3q 70RWCPUc7IGPVvmEbFEg64rDCn8/eJrq3G36BQfisGwCAQmZxIxJd54n5o5nIiR6 HH/UBjK7VXLPgJygs+DPvhky0Tm4Zliwz9Wz8EB/cQhiGR+XNVUXlWzkPdNncrsT c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PTdGkF 2Fbg8VUVYEXuarUB0HC8XM2FbmbfV2iV+75Z0=; b=nbvclThpJUv+ye5lGcuCUm sTqFM/ZdOaaP7Ml3W0Z+Dj5aVIKGxHsd8eEUjNfGXwVMOiP/nTgK+tmzGgB3dp5k Bl8AWu4g8v9A3goA9bWeD9WkJYi2IfjALKmHZUYIjNF+uOrreR1zj/3d2Y8lM/ZO E2IDhqbUsEDWWl28uP0gNwPnPC5/fbRlOzAj9U6vwnCiGelRWdFPrvJt7q/15+pp W1pyEQ6HI+9KU9gfMZLMwm2pGXzf5N700N6wmtPIucXLPs/4ozAa4z7Ei5OcfSpU 0PNG5puDFZ3OWlk/O4p04ttB9cHkgJO5yME+WAkKfmkZpXWTjvnIqjEloC6s1k3w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 291F224C52; Wed, 25 Oct 2017 05:00:01 -0400 (EDT) From: Thomas Monjalon To: "Li, Xiaoyun" Cc: "Ananyev, Konstantin" , "Richardson, Bruce" , dev@dpdk.org, "Lu, Wenzhuo" , "Zhang, Helin" , "ophirmu@mellanox.com" Date: Wed, 25 Oct 2017 11:00:00 +0200 Message-ID: <4158692.mhjs8xbxgm@xps> In-Reply-To: References: <1507206794-79941-1-git-send-email-xiaoyun.li@intel.com> <2601191342CEEE43887BDE71AB9772585FAAEB8E@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2017 09:00:02 -0000 25/10/2017 10:54, Li, Xiaoyun: > > > > > > I think we should focus on micro-benchmark and find a > > > > > > reasonnable threshold for a reasonnable drop tradeoff. > > > > > > > > > > > Sadly, it may not be that simple. What shows best performance for > > > > > micro- benchmarks may not show the same effect in a real application. > > > > > > > > > > /Bruce > > > > > > > > Then how to measure the performance? > > > > > > > > And I cannot reproduce 15% drop on mellanox. > > > > Could the person who tested 15% drop help to do test again with 1024 > > > > threshold and see if there is any improvement? > > > > > > As Bruce said, best performance on micro-benchmark may not show the > > same effect in real applications. > > > And I cannot reproduce the 15% drop. > > > And I don't know if raising the threshold can improve the perf or not. > > > Could the person who tested 15% drop help to do test again with 1024 > > threshold and see if there is any improvement? > > > > As I already asked before - why not to make that threshold dynamic? > > Konstantin > > > I want to confirm that raising threshold is useful. Then can make it dynamic and set it very large as default. You can confirm it with micro-benchmarks.