From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46DB5A04A5; Wed, 17 Jun 2020 14:44:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C2F61252; Wed, 17 Jun 2020 14:44:33 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 13C251150 for ; Wed, 17 Jun 2020 14:44:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592397871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=K4xNPXggxXzprnmIo7EIYJvTlTF1BR7sMz5JcOYArCU=; b=eZluefXkz2la+1hwyQCm9VzFRAU9/YTDAIQyw5xqcOcIy5AEoXuo3SnNSHBxrUxvilgi4j GeL8Y4JTgK4HJlJk4nV9+oVDa78xwQ6mE0olJxpA0c1AahVi7ZxPn+IYs7HO7JaB+c+So/ NJD1P3cXtIg2byonxkh9eHC5X070bZU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-67-4NJMrSCPOPmWdQX1XCMwZw-1; Wed, 17 Jun 2020 08:44:23 -0400 X-MC-Unique: 4NJMrSCPOPmWdQX1XCMwZw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2DDEF10AB650; Wed, 17 Jun 2020 12:44:22 +0000 (UTC) Received: from [10.36.110.7] (unknown [10.36.110.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F2130104B500; Wed, 17 Jun 2020 12:44:19 +0000 (UTC) To: "Xia, Chenbo" , "dev@dpdk.org" , "amorenoz@redhat.com" , "Ye, Xiaolong" , "shahafs@mellanox.com" , "matan@mellanox.com" References: From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <41586984-7541-8d53-6aea-f4eef6dfa1c9@redhat.com> Date: Wed, 17 Jun 2020 14:44:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to Virtio-user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/17/20 2:07 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: dev On Behalf Of Maxime Coquelin >> Sent: Thursday, May 28, 2020 3:46 PM >> To: dev@dpdk.org; amorenoz@redhat.com; Ye, Xiaolong >> ; shahafs@mellanox.com; matan@mellanox.com >> Cc: Maxime Coquelin >> Subject: [dpdk-dev] [PATCH 3/3] net/virtio: add Virtio status support to Virtio- >> user >> >> This patch adds support for VHOST_USER_SET_STATUS request. It is used to >> make the backend aware of Virtio devices status update. >> >> It is useful for the backend to know when the Virtio driver is done with the Virtio >> device configuration. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/net/virtio/virtio_user/vhost.h | 5 +++++ >> drivers/net/virtio/virtio_user/vhost_user.c | 8 ++++++++ >> .../net/virtio/virtio_user/virtio_user_dev.c | 20 ++++++++++++++++++- >> .../net/virtio/virtio_user/virtio_user_dev.h | 1 + >> drivers/net/virtio/virtio_user_ethdev.c | 1 + >> 5 files changed, 34 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/virtio/virtio_user/vhost.h >> b/drivers/net/virtio/virtio_user/vhost.h >> index 260e1c3081..fc360564eb 100644 >> --- a/drivers/net/virtio/virtio_user/vhost.h >> +++ b/drivers/net/virtio/virtio_user/vhost.h >> @@ -57,6 +57,10 @@ struct vhost_vring_addr { #define >> VHOST_USER_PROTOCOL_F_REPLY_ACK 3 #endif >> >> +#ifndef VHOST_USER_PROTOCOL_F_STATUS >> +#define VHOST_USER_PROTOCOL_F_STATUS 15 #endif >> + >> enum vhost_user_request { >> VHOST_USER_NONE = 0, >> VHOST_USER_GET_FEATURES = 1, >> @@ -77,6 +81,7 @@ enum vhost_user_request { >> VHOST_USER_SET_PROTOCOL_FEATURES = 16, >> VHOST_USER_GET_QUEUE_NUM = 17, >> VHOST_USER_SET_VRING_ENABLE = 18, >> + VHOST_USER_SET_STATUS = 36, > > I see in qemu's vhost-user spec (https://www.qemu.org/docs/master/interop/vhost-user.html#protocol-features) > that '36' is used by VHOST_USER_GET_MAX_MEM_SLOTS. And I don't see VHOST_USER_PROTOCOL_F_STATUS. > Do I miss something here? Partly, yes :) In the cover letter, I mention that this patch should be applied only once the spec update part of the Qemu series it depends on is merged: " So the first two patches can be applied as-is, while for the last one, we have at least to wait the Qemu bits, which includes the specification update, is merged upstream. " This is a link to the Qemu patch: https://patchwork.ozlabs.org/project/qemu-devel/patch/20200514073332.1434576-1-maxime.coquelin@redhat.com/ > Also, I see in drivers/net/virtio/virtio_pci.h, the status definition is too old and does not align with the spec now. > Should we update that one? Yes, that could be done, feel free to send a patch for this. Thanks, Maxime > Thanks! > Chenbo > >> VHOST_USER_MAX >> }; >> >> diff --git a/drivers/net/virtio/virtio_user/vhost_user.c >> b/drivers/net/virtio/virtio_user/vhost_user.c >> index f8d751c98e..68232d75d7 100644 >> --- a/drivers/net/virtio/virtio_user/vhost_user.c >> +++ b/drivers/net/virtio/virtio_user/vhost_user.c >> @@ -278,6 +278,14 @@ vhost_user_sock(struct virtio_user_dev *dev, >> need_reply = 1; >> break; >> >> + case VHOST_USER_SET_STATUS: >> + if (!(dev->protocol_features & >> + (1ULL << >> VHOST_USER_PROTOCOL_F_STATUS))) >> + return 0; >> + >> + if (has_reply_ack) >> + msg.flags |= VHOST_USER_NEED_REPLY_MASK; >> + /* Fallthrough */ >> case VHOST_USER_SET_FEATURES: >> case VHOST_USER_SET_PROTOCOL_FEATURES: >> case VHOST_USER_SET_LOG_BASE: >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> index ea22af5dc4..cf29ea0b88 100644 >> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> @@ -424,7 +424,8 @@ virtio_user_dev_setup(struct virtio_user_dev *dev) >> >> #define VIRTIO_USER_SUPPORTED_PROTOCOL_FEATURES \ >> (1ULL << VHOST_USER_PROTOCOL_F_MQ | \ >> - 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK) >> + 1ULL << VHOST_USER_PROTOCOL_F_REPLY_ACK | \ >> + 1ULL << VHOST_USER_PROTOCOL_F_STATUS) >> >> int >> virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, @@ - >> 782,3 +783,20 @@ virtio_user_handle_cq(struct virtio_user_dev *dev, uint16_t >> queue_idx) >> __atomic_add_fetch(&vring->used->idx, 1, >> __ATOMIC_RELAXED); >> } >> } >> + >> +int >> +virtio_user_update_status(struct virtio_user_dev *dev, uint8_t status) >> +{ >> + int ret; >> + uint64_t arg = status; >> + >> + /* Vhost-user only for now */ >> + if (!is_vhost_user_by_type(dev->path)) >> + return 0; >> + >> + ret = dev->ops->send_request(dev, VHOST_USER_SET_STATUS, &arg); >> + if (ret) >> + return -1; >> + >> + return 0; >> +} >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h >> b/drivers/net/virtio/virtio_user/virtio_user_dev.h >> index 56e638f8a6..c49a896a88 100644 >> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h >> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h >> @@ -71,4 +71,5 @@ void virtio_user_handle_cq(struct virtio_user_dev *dev, >> uint16_t queue_idx); void virtio_user_handle_cq_packed(struct virtio_user_dev >> *dev, >> uint16_t queue_idx); >> uint8_t virtio_user_handle_mq(struct virtio_user_dev *dev, uint16_t q_pairs); >> +int virtio_user_update_status(struct virtio_user_dev *dev, uint8_t >> +status); >> #endif >> diff --git a/drivers/net/virtio/virtio_user_ethdev.c >> b/drivers/net/virtio/virtio_user_ethdev.c >> index ccb5a18e25..bed161ba07 100644 >> --- a/drivers/net/virtio/virtio_user_ethdev.c >> +++ b/drivers/net/virtio/virtio_user_ethdev.c >> @@ -271,6 +271,7 @@ virtio_user_set_status(struct virtio_hw *hw, uint8_t >> status) >> else if (status == VIRTIO_CONFIG_STATUS_RESET) >> virtio_user_reset(hw); >> dev->status = status; >> + virtio_user_update_status(dev, status); >> } >> >> static uint8_t >> -- >> 2.26.2 >