From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0048.outbound.protection.outlook.com [104.47.2.48]) by dpdk.org (Postfix) with ESMTP id 965A11B22A; Fri, 6 Oct 2017 02:51:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NHPvq8ipuAJBxgfvPoCLoP33h4GcYpTa4eyhHBkdMLA=; b=ZDIaTYpVK/1ldK6DcCUUgaGKqJ5BdMeZlCOO/1gJy+Zw0QW3LkbzXzWiChIS8BS0UPvFNQN1JrUnoB++ftEMG1v2b0qLqN8f8j2a02667uCLqjb8hOLbqbvJIRvY42t7ZaM/ypQ0RMTYZS8+h/JxGYsEMdpPC8tlzjwTX9G62eo= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2048.eurprd05.prod.outlook.com (10.167.195.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 6 Oct 2017 00:51:12 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::84ed:9505:3e7f:9722]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::84ed:9505:3e7f:9722%13]) with mapi id 15.20.0077.018; Fri, 6 Oct 2017 00:51:12 +0000 From: Yongseok Koh To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: "dev@dpdk.org" , Adrien Mazarguil , "ferruh.yigit@intel.com" , "stable@dpdk.org" Thread-Topic: [PATCH v2 07/30] net/mlx5: fix reta update can segfault Thread-Index: AQHTPdiIXBO2V9BbqUuzQrgd2t7hgqLV/raA Date: Fri, 6 Oct 2017 00:51:12 +0000 Message-ID: <415F0EB4-CBF3-4E4E-83F0-E21CD9447B57@mellanox.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2048; 6:i3OMk5xI88pJDl81s9UcJhvxIIoC6ru83gvLiN5iZQkCETUDATUjUDjTixE2+lrgrb8TZx/Cwo9qmosBl1fyzTi3PBTlRFnE9YVEXlrElw+lOFwjzaHDW50sVbLghiSUk57wstyAG4zLbqVE1A5YEQudybNF3eTarM4tt9M7UVNc+Sr4DRY5V4cTnLyvJPiP4JrrEVHAoFTS4yVaYrQ/eMPd5dyJV6mg4BjgQhjCxCzdO6wqG9C/fpPw6S3S9g3YVMzspbLN+ODP+WVUy0XaxaVUTL7tP5ftryAy75AbhySeV9JVCgRTLdeN/w3u4/CS5GXqpVkbDUAawzis9Rty0Q==; 5:2BdYMnAk+tvxyM8YokcuZ3cvCqmh9tYPoTjhGTBFZb+zBnDurJdhw9sx5smTonHJcR2olMOzkgBdPjZY6/mmO+VJVBX+nKqonJmrQ5qWzWZ4kmb/seHpkwJ0EGF0M/vx0eGMIMSCyAIZQLkmXgqxgg==; 24:Rrl3BxD6xMDhNj6061+xgoz70xJq/ZgFn7b7UVcArA/QnxXdD/sOpu7pK+3M1lP6I258gNvmakdEtOPE9EHden+MyRfcRfhjV9icVn8J1vY=; 7:8Ya2YZgKj7vdOsXL0erW+8d7ogns3y1PIR4ocGToZHVG9FLfIanbmX5950aDe8L7pWBUVTukjUWNqkY3QRK8yKtLPZMITdU6DOkKrg0F6lgnnEN//VzNNJokEUPzwrhyuyDLkO4JJw6KFBUb4CQkwzNmpE4Ap0GQAX0FMw44fIFYf6YNA2Db6g35ZISEqCZJefvi/BkUVKXS86JJ9D6OlHr0HKw08KkNmcrqoTk2rZc= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 1ff26861-9df3-4a46-bae1-08d50c54574e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:VI1PR0501MB2048; x-ms-traffictypediagnostic: VI1PR0501MB2048: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR0501MB2048; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR0501MB2048; x-forefront-prvs: 0452022BE1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(376002)(346002)(377454003)(189002)(199003)(24454002)(25786009)(99286003)(105586002)(97736004)(81156014)(81166006)(106356001)(53936002)(76176999)(83716003)(86362001)(54356999)(50986999)(5250100002)(54906003)(478600001)(82746002)(305945005)(101416001)(7736002)(2906002)(189998001)(68736007)(6486002)(2900100001)(229853002)(2950100002)(33656002)(6916009)(53546010)(15650500001)(8676002)(6506006)(6436002)(14454004)(6246003)(66066001)(3280700002)(36756003)(8936002)(4326008)(102836003)(3846002)(5660300001)(316002)(6116002)(3660700001)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2048; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <69BBFB228E1ABB4DB102CE6D6EC29085@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2017 00:51:12.2950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2048 Subject: Re: [dpdk-dev] [PATCH v2 07/30] net/mlx5: fix reta update can segfault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 00:51:13 -0000 > On Oct 5, 2017, at 5:49 AM, Nelio Laranjeiro = wrote: >=20 > Reta update needs to stop/start the port but stopping the port does not > disable the polling functions which may end in a segfault if a core is > polling the queue while the control thread is modifying it. >=20 > This patch changes the sequences to an order where such situation cannot > happen. >=20 > Fixes: aa13338faf5e ("net/mlx5: rebuild flows on updating RETA") > Cc: yskoh@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Nelio Laranjeiro > --- Acked-by: Yongseok Koh =20 Thanks=