From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE635A0567; Tue, 9 Mar 2021 18:50:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B1D922A520; Tue, 9 Mar 2021 18:50:35 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id A503D4069D for ; Tue, 9 Mar 2021 18:50:33 +0100 (CET) IronPort-SDR: sbfCmZlVZHsNXtiSYPjLiKW3OF8J0WcQsR9xknzu+qOfbYHH2AtXopMUVcTIOqtAHGZSU/XzSu MKkwfnEUc9HA== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="167560580" X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="167560580" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 09:50:28 -0800 IronPort-SDR: hGoW888iO0X9iVnusEzidWxkwrR7RQm2Up5I9p0tt76jCpjp//YmBVFm24GAYbdgB679LOo28g NDZYwOoJGuzg== X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="409831485" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.196.3]) ([10.213.196.3]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 09:50:26 -0800 To: Ed Czeck , dev@dpdk.org Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com References: <20210304165637.24658-1-ed.czeck@atomicrules.com> <20210309160818.3553-1-ed.czeck@atomicrules.com> <20210309160818.3553-4-ed.czeck@atomicrules.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <415aa498-d3bd-ca76-77d1-c98816a6f34c@intel.com> Date: Tue, 9 Mar 2021 17:50:23 +0000 MIME-Version: 1.0 In-Reply-To: <20210309160818.3553-4-ed.czeck@atomicrules.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 4/6] net/ark: cleanup ark dynamic extension interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/9/2021 4:08 PM, Ed Czeck wrote: > - Rename extension functions with rte_pmd_ark prefix > - Move extension prototype to rte_pmd_ark.h > - Update local function documentation > > Signed-off-by: Ed Czeck > --- > v3: > - split function rename from previous commit > v4: > - reorder patches renaming before adding <...> > diff --git a/drivers/net/ark/rte_pmd_ark.h b/drivers/net/ark/rte_pmd_ark.h > index 6f26d66b1..0f24a347d 100644 > --- a/drivers/net/ark/rte_pmd_ark.h > +++ b/drivers/net/ark/rte_pmd_ark.h > @@ -1,18 +1,24 @@ > /* SPDX-License-Identifier: BSD-3-Clause > - * Copyright (c) 2020 Atomic Rules LLC > + * Copyright (c) 2020-2021 Atomic Rules LLC > */ > > #ifndef RTE_PMD_ARK_H > #define RTE_PMD_ARK_H > > +#include > +#include > + > +#include > +struct rte_eth_dev; > +struct rte_mbuf; > +struct rte_ether_addr; > +struct rte_eth_stats; > + Is the declaring structures instead of including header preferred intentionally? I guess both works, and it may not differ for the PMD at all, but for the extension developer that is including this header, it may need to include required headers again, this header including all required headers and be a self contained may help extension code, up to you. Plus just a detail but I guess mbuf struct is redundant for this patch, it can be added in next patch where mbufs header removed and hooks added.