From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03DF1A0524; Tue, 1 Jun 2021 09:31:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99E23410F2; Tue, 1 Jun 2021 09:25:17 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 4B648410E7 for ; Tue, 1 Jun 2021 09:25:16 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0BF751209; Tue, 1 Jun 2021 03:25:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 01 Jun 2021 03:25:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= l09C1xw/aCJFmcomB5AOyiemy9VAF3h6bRDy8rdDQZU=; b=FXA0xekxXD0lw9jh nDt3CnIo/ibo6giJ4XpdSe/JSHHo6nEdpQEEIpV7xJr5TgD9xF16SshsoaY5JIiM 780OIzAAq7l3+rORP9+3Jm6BTQwWLdaoAwh+gvawrJu5GSPLvcUpMKYuF/zw51Vb VESoig4hf418YAavfhXa8kYWGDWvLylUVpRStGoCXLuQ4DTR2NWmcgdriknYLcix pXANa8AnE8wgnCeam/TjGKXfWwVrUTM44ax3ANFyU3tGAXc/kFVW6lPyrQESlGv+ X0LjWMBxPY1BhhEWkTju7ii2Zf74V70FLVuFTjMPWiwjhP5l3ott4zN5LFUjE/Kv t2S8zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=l09C1xw/aCJFmcomB5AOyiemy9VAF3h6bRDy8rdDQ ZU=; b=lcr9xP4Q+uZNs/8paYuizsJQCkUMxu+YrWFiFxT0RK9+6meaAmWTI/gGl WZxDxyZPgrKKqMj0z4gF6LNNmyJCOSEuxcXmT+XQRZpo11XGn/fF4+rTLikwOIig /3+iwTGPAtXvZoPSQxzj3ZkXngnaMyKq/+ISz08P4NXWsuL7QiEStQsKcz7lV18Z 3t3eXlZ9oi9gY1WdkZ/XfSrTjhltjX5c9JokplwQ0e9cmg3+oX+RL2XiSP6FQlPf PPwRxgtG4xxMe5CS9/bM3eng52fLtEwBCTYPABNnXAi8pnLHx6ZuD0y4+zxG+Oz7 B1hEbRF8cwLz7DPE4F8xWI07xsxZw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdelgedguddvtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Jun 2021 03:25:10 -0400 (EDT) From: Thomas Monjalon To: dev , Christian Ehrhardt Cc: Nithin Dabilpuram , Anatoly Burakov , Christian Ehrhardt Date: Tue, 01 Jun 2021 09:25:09 +0200 Message-ID: <4162591.McMD3bK3sO@thomas> In-Reply-To: <20210601054247.1540154-1-christian.ehrhardt@canonical.com> References: <20210601054247.1540154-1-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vfio: fix stdbool usage without include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/06/2021 07:42, Christian Ehrhardt: > This became visible by backporting the following for the 19.11 stable tree: > c13ca4e8 "vfio: fix DMA mapping granularity for IOVA as VA" > > The usage of type bool in the vfio code would require "#include > ", but rte_vfio.h has no direct paths to stdbool.h. > It happens that in eal_vfio_mp_sync.c it comes after "#include > ". > > And rte_log.h since 20.05 includes stdbool since this change: > 241e67bfe "log: add API to check if a logtype can log in a given level" > and thereby masks the issue in >20.05. > > It should be safe to include stdbool.h from rte_vfio.h itself > to have bool present exactly when needed for the struct it defines > using that type. A line "Fixes" is missing for the record of the root cause.