From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 73F7056A1 for ; Wed, 21 Mar 2018 15:08:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D74262094E; Wed, 21 Mar 2018 10:08:38 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 21 Mar 2018 10:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=pFpctacM9Ru+D38ip/FzVhp4xt VUGaAzq5B+hYDyju8=; b=oNc7IZwYK6EDkid87DO/xk7G+h3M8qkprLLFFTG3a6 ut2O3OH87GD0fXV/B1B0zAEPHegZQRf4RoredU6PPVwrv8+vyJ6sGfXEBHuSB4Cp DnOgFOO5AgdoV3AeIhehMFNhNud0hD3IVOYZ2BLASWmYYDmFeJ3vSjIycf5V1MF2 U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=pFpcta cM9Ru+D38ip/FzVhp4xtVUGaAzq5B+hYDyju8=; b=Vc2eZ2iaSMECgR2koVZduh nS72g89k6FefvkhhRtWWMZoIpVd4sm1/M04NfWhzQAk/3JFR35KUew9zWgTgyJ4P wdaiqbjUDmq+gvW7/V05QSXts6Qwm2qUbMDaQJLcrByYshe+42kxK8s7ZVCeHUt7 wmATy4WigUcCEsV49nxcQ5U7iVKFKb1H4C2U1IOAKzu3yc8v+OqUe3WBu+OVOQ5l Rvax6YK7KXmTPHxwfKTqymeHrhMc0uq1GAvBsQF/3kpPyfdQkK2oR6EDmEzW1c7j cLeSvwTBECLqHyeVBm0+hSwMM/RlgdIMuWciOsCrKj7oY+vI+Kx9pdTTNpQ8GRRg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9D8447E16E; Wed, 21 Mar 2018 10:08:37 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Shahaf Shuler Cc: dev@dpdk.org, Andrew Rybchenko , John McNamara , Marko Kovacevic , Patil@dpdk.org, Harish , Ivan Malov Date: Wed, 21 Mar 2018 15:08:21 +0100 Message-ID: <4165486.q6vGXG96hz@xps> In-Reply-To: <4a4330be-a8c4-599d-d8a7-3703e5af285c@intel.com> References: <44e451f86e4582815767cf75b4e0f01f5cc60b5f.1507104596.git.shahafs@mellanox.com> <5efda914-7017-9095-2546-ae6e4c627295@solarflare.com> <4a4330be-a8c4-599d-d8a7-3703e5af285c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 14:08:39 -0000 21/03/2018 11:54, Ferruh Yigit: > On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > IMHO, it should be allowed to specify queue offloads on port level. > > It should simply enable these offloads on all queues. Also it will > > match dev_info [rt]x_offload_capa which include both port and queue > > offloads. > > > > Yes, we lose possibility to enable on port level, but disable on queue > > level by suggested changes, but I think it is OK - if you don't need > > it for all queues, just control separately on queue level. > > What I understand was queue offload can only enable more, but it seems it can > both enable or disable. Yes, queue offload should only enable more. An offload enabled at port level, cannot be disabled at queue level. A port offload can be repeated in queue configuration. If a port offload is not repeated in queue configuration, there should be no impact: it is still in the port configuration, thus applying to all queues. About capabilities, the queue offloads must be a subset of port offloads. The queue capabilities show which offloads can be enabled per queue.