From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97915A052A; Wed, 27 Jan 2021 09:25:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FFC9140D1B; Wed, 27 Jan 2021 09:25:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A3394140D1A for ; Wed, 27 Jan 2021 09:25:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611735941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xj4eu5glh74cV1aBOL9kRhsfvB2xJrZ/tCtZWMRAIfE=; b=egRfF2K5to2nzjT6WqhtrTilly2xyzHWTcqbMEpzXxnfQRsplOj9mU87zgPgfiIJ2V8Mi4 Uv/T/NEaJ8y0qQ025hM03O+ii63T1rbK2SfUWC/Q6YCAMaDA6whf1+o5dTCtqkUnUx53Ro I1zUYr62GWjmCx0nUS/o7ISmp5n3D+I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-cXmaa51rPbmTE4--McpLng-1; Wed, 27 Jan 2021 03:25:40 -0500 X-MC-Unique: cXmaa51rPbmTE4--McpLng-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A78810054FF; Wed, 27 Jan 2021 08:25:39 +0000 (UTC) Received: from [10.36.110.31] (unknown [10.36.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D35CA5D748; Wed, 27 Jan 2021 08:25:34 +0000 (UTC) To: David Marchand Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata , Ray Kinsella References: <20210126101639.250481-1-maxime.coquelin@redhat.com> <20210126101639.250481-3-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <4168176c-acce-b1fc-b80e-f796ae73d6a0@redhat.com> Date: Wed, 27 Jan 2021 09:25:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 02/44] bus/vdev: add driver IOVA VA mode requirement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/27/21 9:23 AM, David Marchand wrote: > On Tue, Jan 26, 2021 at 11:16 AM Maxime Coquelin > wrote: >> >> This patch adds driver flag in vdev bus driver so that >> vdev drivers can require VA IOVA mode to be used, which >> for example the case of Virtio-user PMD. >> >> The patch implements the .get_iommu_class() callback, that >> is called before devices probing to determine the IOVA mode >> to be used, and adds a check right before the device is >> probed to ensure compatible IOVA mode has been selected. >> >> It also adds a ABI exception rule to accommodate with an >> update on the driver registration API >> >> Signed-off-by: Maxime Coquelin >> Signed-off-by: David Marchand > > I only suggested some changes. > This patch looks good to me. > Can you change this Sob as a Acked-by? Sure, I can do that. Thanks! Maxime > Thanks Maxime. >