From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 6CFB5AFCE for ; Tue, 27 May 2014 11:18:27 +0200 (CEST) Received: by mail-wi0-f181.google.com with SMTP id n15so1288607wiw.8 for ; Tue, 27 May 2014 02:18:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=k+C5T892pLBNAv1o3P8QzHE+8ZG8l4ORPqmzMRROVWk=; b=QXiA0H8MZtN4mS6qHInZFAtiswAYrC7tNV1apzo0dfzrvhILjm4wd0Z1U1TvdfIY0R QyPl0sq1INY0TIQgf1WnTXh1d2cSv/fTZgzrZStP3Nxo9Qc8kAE4XjV11x7vPJw1m6CR 3urOSCM2lL6WKA713UxOIha1YQ+DprIVIK8oU0tZxyo3MnrDErpFqAHO5g6pJwwnatVM FwdgLDcNk6dDLA4GcnLa7gY+NuQ0xtlmPnHFAYQTpyHh60CcejidPoOCTnhtdHR8K+J4 dID3w+WVbXdrGWfDt34M0mzSAQSTUSAo6tMANBGn0G8oe5XwxIDxjLE8LdW/qo8NUh6Z DSIg== X-Gm-Message-State: ALoCoQm9iFGK3BVk1XqgOtCznya/gjQxZ6WedCjIJ4aYlIc14Tp10lIUybw6nie9sUp13+0uYVDl X-Received: by 10.194.62.176 with SMTP id z16mr37020880wjr.76.1401182318284; Tue, 27 May 2014 02:18:38 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id na4sm6727425wic.21.2014.05.27.02.18.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 May 2014 02:18:37 -0700 (PDT) From: Thomas Monjalon To: "Ming, LiX" Date: Tue, 27 May 2014 11:18:34 +0200 Message-ID: <4169898.AcYyTuYMh1@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <0976FC66838DDE4585886952506C9436FBA620@SHSMSX104.ccr.corp.intel.com> References: <1400895442-32433-1-git-send-email-jingjing.wu@intel.com> <1400895442-32433-2-git-send-email-jingjing.wu@intel.com> <0976FC66838DDE4585886952506C9436FBA620@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/4]ethdev: add ethdev APIs for NIC filters of generic filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2014 09:18:27 -0000 Hi LiX, Thanks for testing patches. In order to be more efficient next times, I have same comments as for HuilongX. 2014-05-27 07:57, Ming, LiX: > This patch adds APIs for NIC filters list below: > ethertype filter, syn filter, 2tuple filter, flex filter, 5tuple filter 1) When replying to an email, there should be "> " in front of lines you have not written. Here, it's not easy to see what you are replying. > Test-by: lmingX lix,ming@intel.com 2) If you do some tests (other than compiling), please explain what are the tests (command lines and environment). > Compile pass 3) No need to notify that compilation is working. It's implicit (and mandatory) when sending a patch. > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index a5727dd..afd4fe8 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c 4) Please do not copy all the patch if you have nothing specific to say about it. Thanks for your help -- Thomas