From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C287DA00BE; Mon, 14 Mar 2022 09:41:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56AF540DF4; Mon, 14 Mar 2022 09:41:44 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id DE7B040DDD; Mon, 14 Mar 2022 09:41:42 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 88D175C01F6; Mon, 14 Mar 2022 04:41:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 14 Mar 2022 04:41:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=d/1gVzHldR1Hyv 88LHr7WFte8/wZG8847ILDwV5L/0Y=; b=GIwc8/thmZWDsAygk1KBhsEfzZnJAW S1oFO79yRWOoNpEtrHjVf3kcNrlL5lqyRvje/w6+VA8ojRuzLFbME4N87eMdPfuN jb1ZBTC92opWACeBaBz4+vpIZCwqYoQ8llvpqZt93lQiyS6FPXLgKZYI0YLWkW/0 6Xz0LY3cgqnr0kc2Tsv+e00D3Y+LUD7JcwVedjoLOkXpGwhaeRZ/tXXXrYPdnPJG /nUiYuBdD9ZV/5ty9uKYP+3dZYJ4GKG4pBOd5f7m4D7egsXm+8Kcy8fx4zpWtu+G cBRIgG+VHEEaLsKNguWgfy09c6t39vt61nLSsPZPVClWHBiSj9QMIubg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=d/1gVzHldR1Hyv88LHr7WFte8/wZG8847ILDwV5L/ 0Y=; b=BWzwBZm2pgidQPJu6IGQcfQZJTTXRY6uenx8ke1XIgy3LFEFAU4/Vn7x7 rVAGl9EaBblhpIVzRGieC6tHP2tmtkIy/kWkBWoDQEhxKXPBHX/ueeMbaQHSEns/ Usw8Gcv28Q3tPgaqLfoY9UyvDRmeLSlw516dPrOmdBR2Brpiwh4sTHIaumeHDluD 9OMGc1Zqm4yPlvxju0taOnk/6VeaxMxgInWjESn2aXZ0Bl7gc1NnBs3JnypuhR1J 2vc57o9uTMf0zsGIqVI0+cAlZ/tp9BTUCVLFbDbL1shPk8Qas0QoJGCeAZJA/bSa gZel2+M2ocbbzkOtPFTJ16sPXy1aA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvjedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 14 Mar 2022 04:41:41 -0400 (EDT) From: Thomas Monjalon To: Junxiao Shi Cc: stable@dpdk.org, "dev@dpdk.org" , "stable@dpdk.org" , "Loftus, Ciara" Subject: Re: [PATCH] net/af_xdp: fix custom program loading with multiple queues Date: Mon, 14 Mar 2022 09:41:40 +0100 Message-ID: <4172267.ejJDZkT8p0@thomas> In-Reply-To: References: <2c42e3e23c18fd60@cs.arizona.edu> <3163221.44csPzL39Z@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/03/2022 12:12, Loftus, Ciara: > > > > 10/03/2022 09:49, Loftus, Ciara: > > > > When the PMD is configured to load a custom XDP program, it sets > > > > XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag to prevent libbpf from > > > > loading its default XDP program. However, when queue_count is set to > > > > greater than 1, this flag is only set for the first XSK socket but not > > > > for subsequent XSK sockets. This causes XSK socket creation failure. > > > > > > > > This commit ensures that XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD flag > > is > > > > set for all XSK socket creations when custom XDP program is being used. > > > > > > > > Fixes: 01fa83c94d7e ("net/af_xdp: workaround custom program loading") > > > > > > > > Signed-off-by: Junxiao Shi > > > > > > Thanks for the patch! > > > It's probably too late to make it into 22.03 but cc-ing stable as it should be > > backported to 21.11.x. > > > > > > Acked-by: Ciara Loftus > > > > I can take it in -rc4. How much are you confident there is no regression? > > > > Thanks. I am confident there is no regression. Applied, thanks.