From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Harish Patil <harish.patil@qlogic.com>,
Rasesh Mody <rasesh.mody@qlogic.com>,
Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH] qede: fix icc build error
Date: Fri, 13 May 2016 17:27:37 +0200 [thread overview]
Message-ID: <4172562.nTvhj9kABG@xps13> (raw)
In-Reply-To: <D3578A37.18DDD%harish.patil@qlogic.com>
> >fix errors:
> >icc: command line warning #10006: ignoring unknown option
> >'-Wno-unused-value'
> >icc: command line warning #10006: ignoring unknown option
> >'-Wno-format-nonliteral'
> >icc: command line warning #10006: ignoring unknown option
> >'-Wno-shift-negative-value'
> >qede/base/ecore_dev.c(1643): error #188: enumerated type mixed with
> >another type
> > return 0;
> > ^
> >
> >Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Looks good.
> I hope its retested against gcc/clang also to make sure the change doesn’t
> cause build errors.
>
> Acked-by: Harish Patil <harish.patil@qlogic.com>
Fixes: ec94dbc57362 ("qede: add base driver")
Applied, thanks
prev parent reply other threads:[~2016-05-13 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 11:23 Ferruh Yigit
2016-05-10 20:02 ` Harish Patil
2016-05-11 17:17 ` Ferruh Yigit
2016-05-13 15:27 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4172562.nTvhj9kABG@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).