DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ixgbe: support X540 VF
Date: Thu, 11 Dec 2014 00:23:24 +0100	[thread overview]
Message-ID: <4172805.tCufcf6XqG@xps13> (raw)
In-Reply-To: <20141209083724.1a6872ac@urahara>

2014-12-09 08:37, Stephen Hemminger:
> Add missing setup for X540 MAC type when setting up VF.
> Additional check exists in Linux driver but not in DPDK.
> 
> Signed-off-yb: Bill Hong <bhong@brocade.com> 
> Signed-off-by: Stephen Hemminger <shemming@brocade.com>
> 
> --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c	2014-12-08 09:26:18.150170081 -0800
> +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c	2014-12-08 09:26:18.150170081 -0800
> @@ -1911,7 +1911,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_
>  	/*
>  	 * Modification to set VFTDT for virtual function if vf is detected
>  	 */
> -	if (hw->mac.type == ixgbe_mac_82599_vf)
> +	if (hw->mac.type == ixgbe_mac_82599_vf ||
> +	    hw->mac.type == ixgbe_mac_X540_vf)

What about X550? Should it be listed there?

>  		txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));
>  	else
>  		txq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));
> @@ -2198,7 +2199,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_
>  	/*
>  	 * Modified to setup VFRDT for Virtual Function
>  	 */
> -	if (hw->mac.type == ixgbe_mac_82599_vf) {
> +	if (hw->mac.type == ixgbe_mac_82599_vf ||
> +	    hw->mac.type == ixgbe_mac_X540_vf) {
>  		rxq->rdt_reg_addr =
>  			IXGBE_PCI_REG_ADDR(hw, IXGBE_VFRDT(queue_idx));
>  		rxq->rdh_reg_addr =

It appears to be a fix which is candidate for 1.8.0.

Thanks
-- 
Thomas

  reply	other threads:[~2014-12-10 23:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 16:37 Stephen Hemminger
2014-12-10 23:23 ` Thomas Monjalon [this message]
2014-12-10 23:43   ` Stephen Hemminger
2014-12-17  0:03 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4172805.tCufcf6XqG@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).