From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FD99A0093; Tue, 8 Mar 2022 23:05:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D82E140395; Tue, 8 Mar 2022 23:05:54 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id DC5FE40141 for ; Tue, 8 Mar 2022 23:05:52 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2A1C15C01A5; Tue, 8 Mar 2022 17:05:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 08 Mar 2022 17:05:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=/y4yM0c86FanU4 LbPcAey7DnBlcl3nvF0cmLDuM9By0=; b=csO8lmi6bbzg0lxwdmRBo9HYPg/OKU vCY/5/XJHazGboIwasr72MFnrKvU5J8wYRhQ2YhTdj/7+ro5O5Na9YnpSH+9u25j +aOn35u3GOL+j+CEN/jGUa15ngYRPcfX2B1xgnL/9/2fKOx107y/tUpm2FG02Oy7 rZz1d4XNm7VMYD1u2jd3OViMUItpcdKUAin0ZkIwqQfKMBnbDCLtNJSH0re6N04x u4KypbiR3qQJ5Im7T0gh8EmVXLGicRpUCTy/yV7ZiE/SkG8OOvluaXD14Wys+UDT o1cl4JnH1ptsU9dmRUINcUN5Twsey1Gw3IRyMtaJhsnGLJkVgQkraBCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/y4yM0c86FanU4LbPcAey7DnBlcl3nvF0cmLDuM9B y0=; b=a6JBAMn02hj/o30NwTNMGkPY5jNTbtGf7C91N+Dk6V3Obt0fe+A5fuE7O zxdUoPqk8AmVUYJfMMQs+6dS8Gjb240pVii8L0LNBmsKAAFixpuxljBWEG0Z2Fej ybocvg8IKpR83zyYGpV2Ol13CQSvIhOx9/TB9MlSP8HJXebiL7YyB6pp9hJjgBeh El9cCSU/nEGWe1zGmg/MfTSZLCNQnTAaqNFaA58RRK54MmNtVlqjw0GDJaqoXDsg 185heB4y/h2hLAL2tY40RmWMklFZ+At2DgaPCZcJ160QT9eO1rmxmQT26RWDqDJF YCx7s0m4mUQuw1sXEZKUBe2C1QE5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduiedgudehhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeeh teffvdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Mar 2022 17:05:50 -0500 (EST) From: Thomas Monjalon To: Liang Ma Cc: dev@dpdk.org, Usama Arif Subject: Re: [PATCH] devtools: fix symbols check Date: Tue, 08 Mar 2022 23:05:49 +0100 Message-ID: <4176712.K71DO8KEF6@thomas> In-Reply-To: References: <20220308211859.3677476-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/03/2022 22:27, Liang Ma: > On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote: > > In some environments, the check of local symbols catch-all > > was failing. Note: this script is called during the build. > > > > The reason is that grep returns an error if nothing is found. > > The option -e of the shell script makes this error fatal. > > It is not always fatal because the grep is in a command substitution. > > > > Fixes: b403498e1422 ("build: hide local symbols in shared libraries") > > > > Reported-by: Usama Arif > > Signed-off-by: Thomas Monjalon > > --- > > devtools/check-symbol-maps.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh > > index 8266fdf9ea..32e1fa5c8f 100755 > > --- a/devtools/check-symbol-maps.sh > > +++ b/devtools/check-symbol-maps.sh > > @@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then > > ret=1 > > fi > > > > -local_miss_maps=$(grep -L 'local: \*;' $@) > > +local_miss_maps=$(grep -L 'local: \*;' $@ || true) > reviewed-by Liang Ma > > I'm curious to know how can the CI passed with original patch..... You are suggesting I did not check the CI. The Intel check failed because of an apply issue, so I was not able to see the compilation result: http://mails.dpdk.org/archives/test-report/2022-March/267685.html Later in the day, the UNH CI failed for the good reason but it was too late, the patch was applied: http://mails.dpdk.org/archives/test-report/2022-March/267723.html That's what happens when I want to introduce a little additional check at the last minute before a release candidate.