From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78AEAA0555; Wed, 25 May 2022 17:46:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0846542BBD; Wed, 25 May 2022 17:46:23 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 2E3EA42BBA; Wed, 25 May 2022 17:46:21 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 73E8A5C0172; Wed, 25 May 2022 11:46:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 25 May 2022 11:46:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653493580; x= 1653579980; bh=Vhs94dx8dCqmwknHkC5d/5+jAILURzGm47Ov9JMkAds=; b=T 3Xnxgss/o0zf4ui8jWw4UlxFPTz00Jlmdm20w5ERGdsiTV9Ingt7mjlH0ULPc+Up vRh2fz57EEcYJYrwEcAC8AKlE1eJZeelTECm1qjz6KotZRb9mbuJd7+cWqAw/y2Z gzSJUcsU0IdSaoWGGsOm2tE5aS7TNwqQiYL0+hxRcXtK+O838tLvAQG9UkA344yh vEdSJSEJqyc6RKVPpl/532I3mFzMqC4hPplmMLzNboY0+ae8xZFmm4iAvEfwK5XE L2rRJ8X9xunmrZB47YoW9EOrglfqNWH0gH1O3YFVw9yvhlalaGkTmTTM5pGL4kZx +HGtJvWTAROqCaJw9Hz1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653493580; x= 1653579980; bh=Vhs94dx8dCqmwknHkC5d/5+jAILURzGm47Ov9JMkAds=; b=Z rYKEDc1WOLz3noscA/k8pt7LLrcYd13JCMwqqgZCT4NoKFIWm+h2dTNu077G7X4O H7bPfptYrlk6SSmCqYaMuh/UBbBuEPSUKNz8ahtB2XfrxYk/SwqAUfQN0Wqphs/k RDd4orlIQ6Uw42zHTsD1pegdtBroN+DGtiY+vaDU36Y8sXTZ0oW0WWw1XCMPRQcR 5c0yAlMpeSaLf6e9+n4q9L/YJLEAzezr31RZdKuHnn6CAbSxhGx0q09HcNdezZah sBu6LyMPE+ZtaJE9K+7AIBXEav8zaYDEH/bu5EFVCuXITKgnbIGMdLoN7qRzJY6w lzk2Rbp130yP2W5h99JfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeehgdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 May 2022 11:46:18 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad , Xiaoyun Li , Aman Singh , Yuying Zhang Subject: Re: [PATCH v3 1/2] app/testpmd: do not poll stopped queues Date: Wed, 25 May 2022 17:46:11 +0200 Message-ID: <4176885.QLehXeTyEo@thomas> In-Reply-To: <20220307125351.697936-2-dkozlyuk@nvidia.com> References: <20220306232310.613552-1-dkozlyuk@nvidia.com> <20220307125351.697936-1-dkozlyuk@nvidia.com> <20220307125351.697936-2-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/03/2022 13:53, Dmitry Kozlyuk: > Calling Rx/Tx functions on a stopped queue is not supported. > Do not run packet forwarding for streams that use stopped queues. > > Each stream has a read-only "disabled" field, > so that lcore function can skip such streams. > Forwarding engines can set this field > using a new "stream_init" callback function > by checking relevant queue states, > which are stored along with queue configurations > (not all PMDs implement rte_eth_rx/tx_queue_info_get() > to query the state from there). > > Fixes: 5f4ec54f1d16 ("testpmd: queue start and stop") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > Acked-by: Matan Azrad This patch is waiting for long without any comment. Applied in next-net, thanks.