From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7C5173DC for ; Thu, 8 Dec 2016 12:07:15 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 08 Dec 2016 03:07:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,319,1477983600"; d="scan'208";a="1069552632" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga001.jf.intel.com with ESMTP; 08 Dec 2016 03:07:13 -0800 To: Qiming Yang , dev@dpdk.org References: <1479375779-46629-2-git-send-email-qiming.yang@intel.com> <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <1481008582-69416-2-git-send-email-qiming.yang@intel.com> From: Ferruh Yigit Cc: Thomas Monjalon Message-ID: <4177103b-21af-403c-ad3f-6ab1fac94903@intel.com> Date: Thu, 8 Dec 2016 11:07:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481008582-69416-2-git-send-email-qiming.yang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/5] ethdev: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 11:07:16 -0000 Hi Qiming, On 12/6/2016 7:16 AM, Qiming Yang wrote: > This patch adds a new API 'rte_eth_dev_fwver_get' for fetching firmware > version by a given device. > > Signed-off-by: Qiming Yang <...> > @@ -1444,6 +1448,7 @@ struct eth_dev_ops { > /**< Get names of extended statistics. */ > eth_queue_stats_mapping_set_t queue_stats_mapping_set; > /**< Configure per queue stat counter mapping. */ > + eth_fw_version_get_t fw_version_get; /**< Get firmware version. */ Hi Qiming, Not sure if I am missing something but this change is for following [1] deprecation notice, right? If so, notice suggest updating rte_eth_dev_info_get() to include fw_version, but this patch adds a new eth_dev_ops. Is it agreed to add a new eth_dev_ops for this? [1] * In 17.02 ABI change is planned: the ``rte_eth_dev_info`` structure will be extended with a new member ``fw_version`` in order to store the NIC firmware version. > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > /**< Get packet types supported and identified by device*/ <...>