From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C646FA046B; Thu, 9 Jan 2020 15:13:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9AAB31DDE2; Thu, 9 Jan 2020 15:13:31 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id EFDED1C1B9; Thu, 9 Jan 2020 15:13:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 4462081B8; Thu, 9 Jan 2020 09:13:28 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 09 Jan 2020 09:13:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jN4r/WJvX5l1Ks4M186dPXjZMdanL38OzBcQ7PX8sTs=; b=prV9bw+ZMb2M /60kWPpZRREtxV7b5SdsktCF5B4NHDrGt0rHfCtyfFroZtPOWO5qmCeTNTTfX7hp ksoCIL4ThrZ3lP8gXpnvi6YZOWeNSDKzBPIAzq8Z9ucDaTMNaadlQ2zVebOZ6C+p dfr6o46v5KvBnWHlsPxrR21PSZhbdWU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=jN4r/WJvX5l1Ks4M186dPXjZMdanL38OzBcQ7PX8s Ts=; b=EHYHu23m/Ca5VKXSEFY8DPwnNizzVTb40Xf7Rh1R4la7vpdi9H+U5kIW2 +BPrQKjF+Y3LvY4H+T19Kves/NGxD5WukM4RnMv/UMn6CSv1AqQLhJJrnBMyAKCK e7nIM32Yug2GnmZ7BCNP8rN4SYDUVRDaPYDRwFgYaFyTJd+IWz+EENNQG1AnVFBW z3xrseQHcqkLVgl3OJ750LUgvjGzyeY2EC6ITKAKgxUT8EdJdeYNxeTPc5BaJAMR hruCJS/P3z62oszvGPUA1tdS26kKDsE7nM0sHhklPLWidf4RWJmzyW50KO/oCLUN kwF5GX2XNXjxkGT3S6uDkKnkg/D7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdeiuddgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BBA5F30600A8; Thu, 9 Jan 2020 09:13:24 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: nhorman@tuxdriver.com, dev@dpdk.org, stable@dpdk.org, arybchenko@solarflare.com, mdr@ashroe.eu, stable@dpdk.org, John McNamara , Marko Kovacevic , Qiming Yang , Wenzhuo Lu , Nicolas Chautru , Declan Doherty , Adrien Mazarguil , Ferruh Yigit , Cristian Dumitrescu , Honnappa Nagarahalli Date: Thu, 09 Jan 2020 15:13:23 +0100 Message-ID: <4177191.8F6SAcFxjW@xps> In-Reply-To: <20191202152030.7800-1-david.marchand@redhat.com> References: <20191125161314.18804-1-david.marchand@redhat.com> <20191202152030.7800-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] mark experimental variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/12/2019 16:20, David Marchand: > So far, we did not pay attention to direct access to variables but they > are part of the API/ABI too and should be clearly identified. > > Introduce a __rte_experimental_var tag and mark existing exported > variables. > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > + elif grep -qe "\(\.data\|\*COM\*\).*[[:space:]]$SYM$" $DUMPFILE && > + ! grep -q "\.data\.experimental.*[[:space:]]$SYM$" $DUMPFILE I like such regex ;) I don't know COM section but I am not an ELF expert. Maybe you can just add a comment in the commit log about searching the symbol in .data and COM sections, even if we don't know exactly why. One more comment for the record, I would like we avoid having some variables in the ABI. Feel free to push this patch. Acked-by: Thomas Monjalon